Bug 168115

Summary:	forgets to remind again when restarted
Product:	[Applications] korganizer	Reporter:	Matthias Heinz <mh>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nesnera, scott1
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	patch which fixes the bug

Description Matthias Heinz 2008-08-02 16:04:11 UTC

Version:            (using KDE 3.5.9)
Installed from:    Debian testing/unstable Packages

Hi,

if i add an appointment, tell it to remind me 10 minutes before, then tell the reminder dialog to remind me again in 2 minutes and then restart korganizer, the re-reminder doesnt go off. In fact i haven't found any entry in the config files where me re-reminder got saved.

This makes korganizer partly unusable. Think of a big event, let you remind 10 days before it, tell korganizer then to reremind you in 5 days again, and forget the event completly, because you switch your computer on and off every day.

There's a way to avoid this: Save re-reminders like the original reminder in the .ics file, add another option where you save "reminded" (true/false) and its even possible to remind on missed events, when korganizer wasn't running.

Please fix this, it worked great in earlier versions, but somehow got disabled.


Yours sincerely,
Matthias

Comment 1 Matthias Heinz 2008-08-03 16:25:43 UTC

Well, i just tested this with a live distribution and kde 4.1

This bug is still present in the newest version of korganizer.

Comment 2 Bram Schoenmakers 2008-09-14 11:55:40 UTC

*** Bug 170891 has been marked as a duplicate of this bug. ***

Comment 3 Bram Schoenmakers 2008-09-14 11:56:25 UTC

*** Bug 167634 has been marked as a duplicate of this bug. ***

Comment 4 grashdur 2008-09-14 22:08:25 UTC

Yes, this is a real problem. Let me also add, to clarify the problem as I experience it: 

Once an event reminder pops up, that same reminder will never pop up again on subsequent restarts of the program, even if that reminder has not been "dismissed." This means that you can easily miss appointments and tasks to be done.

Comment 5 Pedro Miguel Silva 2008-09-15 12:23:15 UTC

*** This bug has been confirmed by popular vote. ***

Comment 6 Matthias Heinz 2008-10-24 01:49:40 UTC

Hi,

I did some digging and testing and found out that this bug is a problem of korgac. It got a major rework from 3.5.8 to 3.5.9.

My first thought was that the reminders - that could be missed while korgac is not running - weren't saved when korgac exits. Not true, this works fine.

But when they get reread again at start they somehow gets lost. I couldn't find out the problem here, yet. The code for reading the config file didn't change since 3.5.8.

(That korgac doesn't save the reminders immediately is another problem. korgac could crash, the computer could crash... such informations should be stored on disk as soon as possible)


Regards,
Matthias

Comment 7 Matthias Heinz 2008-10-24 21:12:28 UTC

Created attachment 28117 [details]
patch which fixes the bug

Comment 8 Matthias Heinz 2008-10-24 21:12:55 UTC

This was a hard one, but the attached patch fixes it.

Comment 9 Allen Winter 2008-10-25 00:46:32 UTC

SVN commit 875622 by winterz:

A possible fix for "forgets to remind again when restarted".
Matthias and I worked together to improve his original patch.
We'll test this in the 3.5 branch and trunk for a couple days
and see if it works.  Then backport and close this bug if it does.

CCBUG: 168115


 M  +3 -4      alarmdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=875622

Comment 10 Allen Winter 2008-10-25 14:47:59 UTC

SVN commit 875741 by winterz:

undo last night's over-aggressive changes and revert back to Matthias's
original patch, which simply uses the correct 1-up counter on the
name of the configfile group "Incidence-%1"

Since Matthias has been using the patch for a while and reports
that it works, and it makes sense to me, I will close this bug.

BUGS: 168115


 M  +4 -3      alarmdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=875741