Bug 167545

Summary:	Konqueror's »Home«-button lacks context
Product:	[Applications] konqueror	Reporter:	Jan Holthuis <jan>
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	tr
Priority:	NOR
Version First Reported In:	SVN
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	switch Text+Tooltip+WhatsThis of Home action for filemanager + browser

Description Jan Holthuis 2008-07-27 21:09:07 UTC

Version:           4.00.98 (using KDE 4.0.98)
Installed from:    Ubuntu Packages
OS:                Linux

The german label of the Home-Button in Konqueror is wrong.

Translated into german, this is »Persönlicher Ordner« (»home folder«), but »Startseite« (»home page«) would be correct. However, the tooltip »Zur ”Startseite“ wechseln« is properly translated.

Comment by Burkhard Lück on the mailing-list [translated]:
→ http://lists.kde.org/?l=kde-i18n-de&m=121717946721096&w=2
> 
> Konqui has two modes, filemanager and webbrowser.
> In both, Home has a different meaning.
> 
> As filemanager:
>         Symbol          Button+Menu             Short Info
> en      Ok              Home                    Navigate to your 'Home Location'
> de      Ok              Persönlicher Ordner     Zur "Startseite" wechseln
> As Browser:
>         Symbol          Button+Menu             Short Info
> en      Ok              Home                    Navigate to your 'Home Location'
> de      Ok              Persönlicher Ordner     Zur "Startseite" wechseln
> 
> In the settings: Home Page - Startseite
> 
> Looks like a missing context or wrong messages in the code,
> we [the german mailing list] can't do anything about it :-(
> 
> In browser-mode this should be like this:
>         Symbol          Button+Menu             Short Info
> en      Ok              Home Page               Navigate to your 'Home Page'
> As filemanager:
>         Symbol          Button+Menu             Short Info
> en      Ok              Home Location           Navigate to your 'Home Location'

Comment 1 Thomas Reitelbach 2008-08-30 20:35:08 UTC

This is a Konqueror bug, the l10n-team can't do anything about it :(
Re-Assign it to the konqui-people.

Comment 2 Thomas Reitelbach 2008-08-30 20:39:18 UTC

The problem is, that the "Home" Button has a different meaning in file manager mode and web-browser mode.

In the code konqueror uses the same string for this button and it behaves exactly the same, no matter if konqui is used as file manager or as web browser. This means, when konqueror is in file manager mode and i press the home button, it takes me to www.kde.org instead of $HOME. This is kinda funny and a problem for many language teams, because we can't translate this button properly.

Comment 3 Burkhard Lück 2008-09-11 16:53:43 UTC

Created attachment 27370 [details]
switch Text+Tooltip+WhatsThis of Home action for filemanager + browser

- removed comment about icon switch for webbrowsing + filemanager mode, this switch is already done properly

- behind the existing icon switch code I added code to switch Text, ToolTip and setWhatsThis for m_paHome action in webbrowsing + filemanager mode in an similar manner than the icon switch

- deleted the now unnecessary setToolTip, setWhatsThis in KonqMainWindow::initActions()

- I used the terms "Home Folder" (local $HOME), this is hardcoded in filemanager mode; and "Home Page" from the settings page for the webbrowsing mode.

- one strange issue still remains:
in the settings there is a button, which opens a dialog to select a *local* folder for 'Home Page' in webbrowsing mode, this does not make any sense to me.

with this patch it is possible to have proper translations for the two different meanings of this action

Comment 4 Burkhard Lück 2008-11-02 21:07:50 UTC

SVN commit 879247 by lueck:

switch Text+Tooltip+WhatsThis of m_paHome action for filemanager + browser mode
BUG:167545

 M  +6 -7      konqmainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=879247