Bug 167529

Summary:	Image Editor not working correctly after setting "use horizontal thumbbar" option
Product:	[Applications] digikam	Reporter:	Andi Clemens <andi.clemens>
Component:	Thumbs-BarView	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	0.10.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:	0.10.0

Description Andi Clemens 2008-07-27 15:20:22 UTC

Version:           0.10.0-beta2 (using KDE 3.5.9)
Compiler:          Target: i686-pc-linux-gnu
OS:                Linux (i686) release 2.6.25-ARCH

When changing the setting "use horizontal thumbbar" in the settings dialog for the image editor, the thumbbar gets not updated (not moved to the bottom of the screen). Also closing and reopening the editor doesn't help (this is because we use a singleton instance of the editor, which is good for sure).
To fix it digiKam itself has to be restarted, not only the image editor as mentioned in the settings dialog.
But if you change this setting and continue to work with digiKam, it somehow works strange:
- Thumbnails are "gone" and will / or will not be generated new
- After a while digiKam even crashes, but right now I get a different BT all the time

I think we need to have a signal or something like that to change the location of the thumbbar immediately, or we have to change the settings description to "use horizontal thumbbar (needs restarting of digiKam)", but this is not a good option I think.

About the problem with the thumbnails: I have no idea what this could be, maybe I'll get a better BT someday and I will attach it here.

Comment 1 caulier.gilles 2008-07-27 15:26:30 UTC

>I think we need to have a signal or something like that to change the location of >the thumbbar immediately, or we have to change the settings description to "use >horizontal thumbbar (needs restarting of digiKam)", but this is not a good option >I think. 

This is not possible because the layout is hardcoded in source code and cannot be changed in live as well.

Gilles Caulier

Comment 2 Andi Clemens 2008-07-28 21:52:32 UTC

So we need to change the additional comment in the settings dialog?

Comment 3 caulier.gilles 2008-07-28 22:38:54 UTC

Yes this is the first stuff todo. 

For crash, something must be done to not set Thumbbar settings after to have changed configuration panel.

Gilles

Comment 4 Andi Clemens 2008-07-28 22:50:23 UTC

SVN commit 838830 by aclemens:

changed comment concerning use of horizontal bar in image editor

CCBUGS:167529

 M  +2 -2      setupeditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=838830

Comment 5 caulier.gilles 2008-07-30 08:58:00 UTC

Andi,

The crash relevant of thumbbar is not reproductible here, after changing orientation setting. the thumbbar contents is just regenerated (why ?) and take a while, but it still suitable.

I have take a look to make layout of editor customizable on the fly, but it still the hell to do it without to change code indeep. I will take a look into this problem after 0.10.0 release, perhaps to use QDockWidget:

http://doc.trolltech.com/4.4/qdockwidget.html

Gilles

Comment 6 caulier.gilles 2008-07-30 09:18:24 UTC

SVN commit 839499 by cgilles:

do not refresh all thumbbar items if exif rotation flags is not changed.
CCBUGS: 167529


 M  +3 -0      thumbbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=839499

Comment 7 caulier.gilles 2008-07-30 09:19:43 UTC

SVN commit 839500 by cgilles:

backport commit #839499 from KDE3 branch
BUG: 167529


 M  +3 -0      thumbbar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=839500