| Summary: | Color selection in sketch search tool looks plain black [KHueSaturationSelector relevant] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Gandalf Lechner <gandalflechner> |
| Component: | Searches-Similarity | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andi.clemens, caulier.gilles, digikam-bugs-null, rf-kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.10.0 | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
|
Description
Gandalf Lechner
2008-07-20 19:16:25 UTC
Created attachment 26287 [details]
screenshot
I think it is KDE4libs fault, I once had a nice colorful selection tool, but now it is just black, too. I'm not quite sure (never looked at that code before) but I guess this is a standard KDE widget... Andi, Here with KDE 4.0.3, all work fine. I have tested few week ago with KDE 4.1 beta1 and i can reproduce the problem. Sound like a regression from KDELibs. Code relevant is here : http://lxr.kde.org/source/extragear/graphics/digikam/utilities/fuzzysearch/fuzzysearchview.cpp#281 Also, look error messages from the console: there is and HSV color space conversion problem. Classes relevant are KHueSaturationSelector and KColorValueSelector. If the problem come from really KDELibs, I propose to re-assign this bug to KDElibs. But I cannot check this problem now (not KDE 4.1 here). Gilles Caulier It really seems to be a kde problem: When I run digikam 0.10 from a kde3 session, the colour selection tool looks colourful as it should. But from a kde4 (4.1 rc1) session, the box is black. Yes, you are right... I knew that I had seen the color dialog before, and now I know when this was :-) When starting from a KDE3 session, I can see the widget completely, starting in a KDE4 session or at least with the KDE4 env variables set, I can't see it anymore (via xhost or ssh forwarding). I re-assign to KDELibs, since with KDE4.0.x, this problem do not appears. It's relevant of KHueSaturationSelector widget. This problem can be reproduced with KDE 4.1.x. Gilles Caulier I just noticed that the color selection widget works in the HSV imageplugin of digiKam, but not in the sketch tool. I will need to take further investigations on that. Andi Oh I see those are not the same widgets... sorry for this unnecessary post... I'll reassign this one to digiKam since it seems to be the problem with our implementation. Andi Andi, I have tested with a last revision of KDE4 from trunk and Qt4.1 provided by Mandriva cooker, and sound like the bug have been fixed. On Sketch tool, the widget run properlly now. Gilles I'll test that... I played around with the colorChooserModes and I got back my colors. But before touching digiKam code I'll update KDElibs first. Andi The widget works also as it should with the latest kde packages in kubuntu Sorry, that conclusion was too fast - right now the bug seems to be back :-( Either that's due to the digikam checkout I just did, or it is sometimes working, and sometimes not. Nothing has changed in digiKam code so far... I also can still confirm it... *** Bug 169404 has been marked as a duplicate of this bug. *** Ahh damn again I have to post the webSVN link by myself, PLEASE repair the commit keywords!!! SVN commit 850342 by aclemens: colors were not set properly in the fuzzy search widget. This commit fixes the issue. -> new member QColor selColor to hold the currently selected color -> new method setColor() to set the colors in the widgets -> modified slotHSChanged() and slotVChanged() http://websvn.kde.org/?view=rev&revision=829870 |