Bug 166491

Summary:	random feature is broken in amarok2 (SVN)
Product:	[Applications] amarok	Reporter:	David <StormByte>
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	lfranchi
Priority:	NOR
Version:	2.0-SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description David 2008-07-14 03:31:05 UTC

Version:           recent svn (using Devel)
Installed from:    Compiled sources
OS:                Linux

As the title says, random is broken in latest amarok2 trunk.
A way to reproduce would be to add several songs, to enable random, and to play. When next is pressed, the next song is played ALWAYS which is not the behaviour it should have.
Maybe related to #166490?

Comment 1 David 2008-07-14 14:00:17 UTC

I've discovered more things in this issue.
It seems that random is broken *only* is repeat is NOT disabled (i.e. selected repeat playlist, or albums), when repeat is off, random works as expected.

Comment 2 David 2008-07-28 00:45:18 UTC

Can someone review this? I've tried wih a clean amarok install (deleting all amarok related files from ~/.kde

Comment 3 Edward Hades 2008-07-28 01:11:38 UTC

Yeah.

To reproduce: add however many songs you like, enable random->track, repeat->track, click next until you reach end of a playlist absolutely sequentially.

Comment 4 Lydia Pintscher 2008-08-20 12:06:31 UTC

This is fixed now.

Thank you for your report.

Comment 5 David 2008-08-20 15:36:32 UTC

I reopen.
I've tested in svn rev 849896 and it is still present.
Tested with repeat -> playlist and random -> tracks. Absolutely secuential here.

Comment 6 David 2008-08-20 15:38:53 UTC

Also, with trepeat -> playlist and random -> tracks, when a song finishes, the *same* song is played again. If you press manually next, then, that undesired secuential behavior is shown.
Maybe it's worth rewritting from scratch that playlist management (random and repeat)?

Comment 7 Lydia Pintscher 2008-08-20 16:06:45 UTC

Ok more testing: It works here if dynamic mode is turned off and repeat is turned off.

One could argue that random is pointless if you have dynamic mode enabled anyway.
But it at least should work if you have repeat playlist enabled and dynamic mode disabled.

Comment 8 David 2008-08-21 01:17:21 UTC

(In reply to comment #7)
> Ok more testing: It works here if dynamic mode is turned off and repeat is
> turned off.
> 
> One could argue that random is pointless if you have dynamic mode enabled
> anyway.
> But it at least should work if you have repeat playlist enabled and dynamic
> mode disabled.
> 

If never touched the Dynamic option, and by default is false, so this is really an important bug though :)

Comment 9 Leo Franchi 2008-08-23 17:10:11 UTC


*** This bug has been marked as a duplicate of bug 168594 ***