| Summary: | KAnimatedButton doesn't work with Tango throbber | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | James Richard Tyrer <tyrerj> |
| Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, pino |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Tango throbber PNG file | ||
|
Description
James Richard Tyrer
2008-07-07 12:52:11 UTC
Created attachment 25896 [details]
Tango throbber PNG file
This is the 32x32 Tango throbber file.
This is 256 x 128 pixels so it is 4 rows of 8 images.
I'm not aware of a standard. Is this icon installed into the 32x32 directory? Then I guess KAnimatedButton could figure out "oh, this big png is 4 rows of 8 images" doing simple division, and go through that. HOWEVER -- this icon looks like it contains only some overlay, not the full image? In kolourpaint I only see some [monochrome?] things turning, but with a lot of transparent pixels, so obviously not suitable as a dropin replacement for the usual kde animated gear... I think that it just has a clear background. So, the only thing is that the KAnimatedButton has to have a background. I opened it in GIMP and put a white layer behind it and it looks OK. From what I see from the icon naming spec[1] the animated icon (like "process-working") should be multi-frame PNG, so both KDE and Tango have wrong icons for them. Anyway, I just committed in KAnimatedButton for KDE 4.2 the support for animated icons (ie MNG files, for example). When requesting to load an icon with KAnimatedButton, first an animated icon is searched, then the former loading (vertical stip image) is done. What is missing at this point is just converting our artwork in the animation category as MNG (easy task). Does it sound ok, or is the support for the Tango tiled image needed yet? [1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-0.8.html It is OK to use MNG if it works smoothly. I tried an MNG and the KDE-3.5 MNG viewer didn't show it smoothly. However, the FD.o standard needs to be supported by the code. There should be no problem doing both since the KDE throbber is branded (process-working-kde) and the Tango one isn't (process-working). (In reply to comment #5) > However, the FD.o standard needs to be supported by the code. Reread my comment above: since r874171 (two days ago) it is. > There should be no problem doing both since the KDE throbber is branded > (process-working-kde) and the Tango one isn't (process-working). Note we do have an unbranded throbber called "process-working", in a tiled image. SVN commit 901284 by pino: Support tiled animation icons of any grid size (not just 1xN), to be read in an LTR order. As clarified with Rodney Dawes (dobey). CCBUG: 165934 M +13 -13 kanimatedbutton.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=901284 Fixed by Pino commit |