Bug 165244

Summary: No border on Alt-Tab window
Product: [Plasma] Oxygen Reporter: Dotan Cohen <kde-2011.08>
Component: styleAssignee: Camilla Boemann <cbo>
Status: RESOLVED INTENTIONAL    
Severity: wishlist CC: cbo, l.lunak, wstephenson
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Screenshot

Description Dotan Cohen 2008-06-28 23:21:18 UTC 
Version:            (using KDE 4.0.83)
Installed from:    Ubuntu Packages

The Alt-Tab window has no border, so it is difficult to distinguish from windows below it.
Comment 1 Dotan Cohen 2008-06-28 23:22:00 UTC 
Created attachment 25678 [details]
Screenshot
Comment 2 Andreas Pakulat 2008-06-29 10:17:06 UTC 

*** This bug has been marked as a duplicate of 154242 ***
Comment 3 lucas 2008-06-29 10:35:52 UTC 
Not a duplicate. This is about the border on the Alt+Tab window itself while bug 154242 is for the border on the highlighted window.
Comment 4 Andreas Pakulat 2008-06-29 10:54:03 UTC 
Aah, misunderstood. But in that case its a wish, not a bug as its a new feature. And I guess its a wontfix, because that window-list shouldn't have a border, its not a window, you can't resize/move it.
Comment 5 Dotan Cohen 2008-06-29 10:58:10 UTC 
Even if it is not a window, it should have a distinctive border to separate it from what is beneath. Borders are not only used to resize/move. They are visual devices which help the user decide which portions of the screen belong to what.
Comment 6 lucas 2008-06-29 11:12:43 UTC 
In KDE3 there is a 2px black border around the list.
Comment 7 Lubos Lunak 2008-06-29 12:49:26 UTC 
SVN commit 825766 by lunakl:

I'm not sure why this is needed, but it helps the styles draw the frame.
CCBUG: 165244



 M  +1 -0      tabbox.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=825766
Comment 8 Lubos Lunak 2008-06-29 12:50:32 UTC 
Oxygen bug. The tabbox uses "setFrameStyle(QFrame::StyledPanel);" and after the change above Qt styles draw a frame, but not Oxygen.
Comment 9 Camilla Boemann 2008-06-29 13:28:32 UTC 
From the qt docs:
QFrame::StyledPanel draws a rectangular panel with a look that depends on the current GUI style. It can be raised or sunken.

As you set shadow to plain we don't draw anything.

I suggest subclassing from QMenu instead of QFrame. That should give you correct drawing with all styles, and it _is_ a menu after all.
Comment 10 Lubos Lunak 2008-06-29 15:02:55 UTC 
I don't want a shadow, I want a frame. If I wanted no frame, I would have used QFrame::NoFrame. Other styles draw a frame with this setup, so I don't think there's an error in the usage on the KWin side (although I may be wrong there). Also, the alt+tab widget is not a menu.
Comment 11 Matthew Woehlke 2008-07-10 02:39:56 UTC 
> Also, the alt+tab widget is not a menu.

Why not? It seems sufficiently menu-like to me to call it a popup. (In fact, other than the unusual key handling, I can't think of any significant way in which it differs from a popup menu.)
Comment 12 Dotan Cohen 2008-07-10 10:01:16 UTC 
@Matthew: No matter if it is a menu, window, or pizza, it needs to be visually distintive. I think that Lubos' patch fixes that.
Comment 13 Lubos Lunak 2008-07-10 12:46:54 UTC 
If you close one eye, maybe it may look like a menu, but technically it is not a menu.
Comment 14 Lubos Lunak 2009-02-16 22:49:34 UTC 
What do you mean, "unmaintained" ?
Comment 15 Camilla Boemann 2009-02-16 22:51:40 UTC 
Well neither of us seems willing to do something about it
Comment 16 Will Stephenson 2009-03-06 14:30:59 UTC 
Sounds like a case for WONTFIX then - i got a fright when I saw 'UNMA' next to Oxygen bugs.