Summary: | doesnt exports contact to a mobile (Gnokii is not yet configured) | ||
---|---|---|---|
Product: | [Unmaintained] kab3 | Reporter: | Ladislav Nesnera <nesnera> |
Component: | general | Assignee: | Tobias Koenig <tokoe> |
Status: | RESOLVED UNMAINTAINED | ||
Severity: | normal | CC: | mdspam |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Gnokii configuration check patch
Gnokii configuration check patch 2 |
Description
Ladislav Nesnera
2008-06-28 21:40:12 UTC
I have the same problem still :-( Konsole (when I'm trying to do export): Opened configuration file /home/nesnera/.gnokiirc Opened configuration file from memory Added new section global Adding key/value port//dev/ttyS0 Adding key/value port/00:12:62:0d:bb:ff Adding key/value model/6230 Adding key/value initlength/default Adding key/value connection/serial Adding key/value connection/bluetooth Adding key/value use_locking/yes Adding key/value serial_baudrate/19200 Adding key/value smsc_timeout/10 Added new section xgnokii Adding key/value allow_breakage/0 Added new section gnokiid Adding key/value bindir//usr/sbin/ Added new section connect_script Adding key/value TELEPHONE/12345678 Added new section disconnect_script Added new section logging Adding key/value debug/on Adding key/value rlpdebug/off Adding key/value xdebug/off LOG: debug mask is 0x1 Config read from file /home/nesnera/.gnokiirc. Qt: 4.4.0 KDE: 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)) "release 19.3" KAddressBook: 4.1 openSUSE 11, 64-bit It doesn't work to import contacts either *** This bug has been confirmed by popular vote. *** Created attachment 28924 [details]
Gnokii configuration check patch
It looks like a wrong condition in if-statement that checks if Gnokii is configured.
This patch fixes the problem for me.
Qt: 4.4.2
KDE: 4.1.80 (KDE 4.1.80 (KDE 4.2 Beta1))
KAddressBook: 4.1
GNOKII Version 0.6.26
There was actually an API change in 0.6.15: "gn_cfg_phone_load() now returns GN_ERR_NONE on success, instead of true" (from the official ChangeLog). So kaddressbook should check against this value. Created attachment 31947 [details]
Gnokii configuration check patch 2
Checking for a valid gnokii-configuration seems to be of little use as gnokii comes with a sample/default configuration-file placed in /etc/gnokiirc. So this test will always succeed even when the user did not create a custom configuration.
However thanks to Alexander and Marcel I created a patch checking for GN_ERR_NONE.
I run the following tests on my box:
- gnokkii configured via ~/.gnokiirc : import/export works as expected :)
- no ~/.gnokiirc : fallback to /etc/gnokiirc giving an error after quite some time, asking the user to run "gnokii --identify", good enough
- no ~/.gnokiirc nor /etc/gnokiirc : unlikely situation but gives the desired "please configure gnokii" message
We could add a check for the gnokii-api version at compile-time but since the new api had been released almost 2 years ago, I felt this isn't necessary.
Qt: 4.5
Kde: 4.2.1
kaddressbook: 4.2.1
gnokii: 0.6.27
The development of the old KAddressBook will be discontinued for KDE 4.4. Since the new application has the same name, but a completly new code base we close all bug reports against the old version and ask the submitters to resend there reports against the new product. |