| Summary: | Thumbnail bar doesn't hides scroll bar when unneeded | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Javier <javi.azuaga> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | 2.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Scroll bar in thumbnail bar
Hides horizontal scrollbar when uneeded and changes height of thumbnails Hide scrollbar when not necessary |
||
|
Description
Javier
2008-06-26 01:13:57 UTC
Created attachment 25609 [details]
Scroll bar in thumbnail bar
I gave a try at fixing this, but my attempt resulted in an infinite loop (the bar kept showing and hiding...). Not good. Will give another try later. Created attachment 28706 [details]
Hides horizontal scrollbar when uneeded and changes height of thumbnails
This is my first patch, so if there's something wrong, please correct it.
Maybe there is a better comparison than horizontalScrollBar()->isVisible()?
Thanks for the patch. But I just tried it and found it generates quite some flickering when you resize the bar. What happens is that when QListView thinks the content fit without scrollbar, it hides it, causing the thumbnails to grow, to a point where they no longer fit in the view, causing the scrollbar to come back... I worked a bit on it to provide a different patch. It seems to be working, but I do not really like the behavior: - Suppose you have big thumbnails which do not fit the view. - You reduce the view height. The thumbnails shrink and some space appear on the right, but the scrollbar is still there because if it got removed the thumbnails would grow again, making the last thumbnail only partially visible. - You continue reducing the view height to the point where the thumbnails would fit the view without scrollbar. The scrollbar disappear and the thumbnails grow, taking advantage of the free vertical space. This cause a "visual jump": thumbnails were reducing but suddenly they get a bit bigger before resuming reduction. This is not nice. I attach the patch here nevertheless so that you can share your thought about it. Created attachment 28718 [details]
Hide scrollbar when not necessary
Thanks for the patch, Aurelien! Unfortunately, as you can see, it's been ignored for 9 years. :( If this bug is still relevant, please upload it to http://phabricator.kde.org/, which is where KDE coordinates patches and code submissions. I'll make sure it gets seen. |