Bug 164813

Summary:	The digital clock showing PH : MM : pm when configured without seconds
Product:	[Unmaintained] plasma4	Reporter:	A. Jay <a.jay.right.here>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	The digital clock

Description A. Jay 2008-06-24 09:19:04 UTC

Version:            (using KDE 4.0.4)
Installed from:    SuSE RPMs
OS:                Linux

The digital clock showing PH : MM : pm when configured without seconds

Comment 1 manolis 2008-06-24 11:10:20 UTC

What language are you using? 
Smells like a translation problem...

Comment 2 Aaron J. Seigo 2008-06-24 23:31:48 UTC

can you provide a screenshot as well? thanks.

Comment 3 A. Jay 2008-06-25 10:28:51 UTC

Created attachment 25587 [details]
The digital clock

Comment 4 A. Jay 2008-06-25 10:35:07 UTC

I'm using language from default installation. I changed the time format of my desktop with PM : MM : SS  AMPM and the digital clock configured without seconds.

Comment 5 A. Jay 2008-07-02 19:29:38 UTC

I still got the same bug with KDE 4.0.84, btw ..

Comment 6 Anne-Marie Mahfouf 2008-07-02 20:00:14 UTC

1) Provide more information please: what is the language default installation? 
2) "I still got the same bug with KDE 4.0.84" is it also Suse rpms?
3) If you start with a new .kde4 or a new user, what are the steps to reproduce?

We (several of us) worked on Digital Clock and system settings time format to fix bugs last week-end and we could not reproduce that one so please be as precise as possible in helping here.

Comment 7 Anne-Marie Mahfouf 2008-07-02 22:09:27 UTC

OK I eventually got it with the help of Rabauke, you actually edit the TimeFormat field in System Settings Time & Dates to insert spaces. I never would have done that myself so it did not cross my mind one would edit that format.

Anyway, now I can reproduce and I see the bug. The bug will be taken care of!

Comment 8 David Faure 2008-07-03 00:18:21 UTC

Annma sent me a unit test, I'll have a look.

Comment 9 David Faure 2008-07-03 02:00:32 UTC

SVN commit 827443 by dfaure:

Fix formatTime() for the case where we don't want seconds, and the format string has spaces before and after the separator for the seconds. Thanks annma for the unit-test, unit tests make bugs fixable :)
BUG: 164813


 M  +10 -5     localization/klocale.cpp  
 M  +4 -0      tests/klocaletest.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=827443