Bug 164747

Summary:	properties on desktop shortcut lacks some settings
Product:	[Unmaintained] plasma4	Reporter:	Ambroz Bizjak <ambrop7>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	kdelibs patch to allow half-local urls to work second patch, better approach also completly fix Device and Url plugins

Description Ambroz Bizjak 2008-06-23 13:53:23 UTC

Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

In the Desktop plasma widget, right-clicking on a program shortcut and choosing Properties opens a dialog, however the dialog lacks the "Application" tab where it would be possible to change the path to the program and some other things.

To see what I mean, compare choosing Properties on an icon in the Desktop widget, and doing it with Dolphin on the actual .desktop file inside ~/Desktop.

Comment 1 Ambroz Bizjak 2008-06-23 19:53:22 UTC

The kdelibs patch I am attaching fixes this problem and probably some similar ones. The problem was if the URL was something like "desktop:/MyProgram.desktop", the properties dialog tried to open /MyProgram.desktop instead of /home/user/Desktop/MyProgram.desktop.

Comment 2 Ambroz Bizjak 2008-06-23 19:54:16 UTC

Created attachment 25546 [details]
kdelibs patch to allow half-local urls to work

Comment 3 Ambroz Bizjak 2008-06-23 22:56:02 UTC

Created attachment 25550 [details]
second patch, better approach

A patch that fixes it with a better approach.

Comment 4 Aaron J. Seigo 2008-06-23 23:14:01 UTC

SVN commit 823700 by aseigo:

allow the properties dialog to work with local files with wierd urls like desktop:/foo
based on a patch by ambro
BUG:164747


 M  +83 -39    kpropertiesdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=823700

Comment 5 Ambroz Bizjak 2008-06-24 11:52:43 UTC

Unfortunately, the first patch I have sent and the svn commit do not fix all aspects of the properties dialog. More specifically, KUrlPropsPlugin and KDevicePropsPlugin are still broken.

My second patch really is a better approach, since it checks if the files are local in the initial ::supports call, and the plugins which require the file to be local do not even get loaded. Since the local path is read and stored on the beginning, it is unnecessary to translate and check it when writing the file.
I have tested that URL and Device properties work as well when using desktop:/.

Comment 6 Ambroz Bizjak 2008-06-24 14:28:42 UTC

Created attachment 25564 [details]
also completly fix Device and Url plugins

I guess it was not a good idea considering the renaming of the files.
Anyway you should apply this to svn, it the patch that was applied did not add
these checks to all plugins.

Comment 7 Ambroz Bizjak 2008-06-28 18:02:27 UTC

The Device and URL properties sections are unfortunately still not fixed as some ::supports functions have been missed out by the fix in svn. Please apply my last patch, it fixes them. (http://bugs.kde.org/attachment.cgi?id=25564&action=view)

Comment 8 Ambroz Bizjak 2008-07-02 11:53:43 UTC

I'm reopening this.
The Device and URL properties sections are still not fixed.
Patch: http://bugs.kde.org/attachment.cgi?id=25564&action=view

Comment 9 Aaron J. Seigo 2008-07-02 21:53:58 UTC

SVN commit 827373 by aseigo:

more isLocal fixes by ambro.
BUG:164747


 M  +15 -2     kfile/kpropertiesdialog.cpp  
 M  +2 -1      kio/global.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=827373