Bug 164301

Created attachment 25407 [details]
patch #1

Gilles,

what do you think? Can we add this to the final release...? This is really a
little patch that doesn't break anything.

Created attachment 25408 [details]
patch #1

Gilles,

what do you think? Can we add this to the final release...? This is really a
little patch that doesn't break anything.

Andi,

Agree. Go ahead.

Gilles

Yes Sir... :-)

SVN commit 821448 by aclemens:

Album names are searched as well now when using the quickfilter.

BUG:164301

 M  +1 -0      NEWS  
 M  +4 -1      digikam/albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=821448

SVN commit 821456 by cgilles:

backport commit #821448 from KDE3 branch
CCBUGS: 164301


 M  +6 -1      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=821456

Andi, 

I have found a little problem with your patch : the album titles will be filtered only if this condition is true : 

if (settings->getIconShowName()) 
{
}

... getIconShowName() is return true if icon item name is displayed on iconview (file name in fact). This is not related to album title.

This is want mean than album titles will be filtered only when file names are displayed on icon-view. To solve this problem you just need to move album titles filtering code outside this conditional section.

Gilles

So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused.
I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed?
But as for the specific problem you are right of course, I need to move this line somewhere else.

SVN commit 822181 by aclemens:

fixed searching for folder names

CCBUGS:164301

 M  +6 -2      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=822181

SVN commit 822187 by cgilles:

backport commit #822181 from KDE3 branch 
CCBUGS: 164301


 M  +7 -4      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=822187

> So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused.
> I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed?


I am also not sure about this. I.e. the quick filter could always
work, even if filename/caption or tag are not displayed.
Conceptually this is the difference between filtering
according to the "properties" of an image, or according
to what is displayed. Maybe the first is more natural?
(For example for more than a few tags, they are not visible anyway
due to lack of space....)

Best, Arnd

Also if displaying tags, filenames and tags all together is turned off, the quick filter for text search becomes disabled (visually). But if you don't know why this is happening, some might think this is a bug.