| Summary: | Amarok does not submit tracks to Last.fm when listening to Last.fm radio | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Edward Hades <edward.hades> |
| Component: | Internet Services | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | doctor_rock, jcnengel, joffko, kdebugs, kfunk, leinir, lfranchi, projects.gg.aaron, shikamaru, soilkitty |
| Priority: | NOR | ||
| Version: | 2.0-SVN | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Bug Depends on: | 169554 | ||
| Bug Blocks: | |||
|
Description
Edward Hades
2008-06-15 17:28:47 UTC
Works again for me. Was probably a server issue or so. Can't confirm, Amarok 2 still doesnt scrobble last.fm radio tracks! On last.fm you can see what you are playing right now, but tracks you _have played_ dont pop up. With Amarok 1 it works fine. Markey, please check again. i can confirm this behaviour too. If you listen to last.fm radio tracks via the last.fm website.. they do not get scrobbled to your profile. I am guessing this is a recent "feature" change. I'll pop into #audioscrobbler and ask a dev. I was wrong :\ Radio tracks should still be scrobbled.
Here's some debug output.. nothing seems wrong on first glance.
BEGIN: void ScrobblerManager::scrobble(TrackInfo)
"The Rocket Summer – Do You Feel"
amarok: [lastfm] Wrote 1 tracks to "/home/ramblurr/.kde4/share/apps/amarok/outp0ur_submissions.xml"
BEGIN: void ScrobblerManager::scrobble(const ScrobbleCache&)
"outp0ur"
BEGIN: int Scrobbler::submit(const ScrobbleCache&)
"The Rocket Summer – Do You Feel"
BEGIN: void ScrobblerPostRequest::request(const QByteArray&)
"[id:"
"0"
"93"
"s=24444538ea4842f3b64dc7f37bb66263&a[0]=The%20Rocket%20Summer&t[0]=Do%20You%20Feel&i[0]=1215960783&o[0]=L&r[0]=&l[0]=161&b[0]=Do%20You%20Feel&n[0]=&m[0]="
amarok: [lastfm] POST: "s=24444538ea4842f3b64dc7f37bb66263&a[0]=The%20Rocket%20Summer&t[0]=Do%20You%20Feel&i[0]=1215960783&o[0]=L&r[0]=&l[0]=161&b[0]=Do%20You%20Feel&n[0]=&m[0]="
END: void ScrobblerPostRequest::request(const QByteArray&) [elapsed: 0 ms]
END: int Scrobbler::submit(const ScrobbleCache&) [elapsed: 0 ms]
amarok: [lastfm] statusChanged: statusCode= 2
END: void ScrobblerManager::scrobble(const ScrobbleCache&) [elapsed: 0 ms]
END: void ScrobblerManager::scrobble(TrackInfo) [elapsed: 1 ms]
amarok: [lastfm] POST: "s=24444538ea4842f3b64dc7f37bb66263&a=mewithoutYou&t=Seven%20Sisters&b=Catch%20for%20Us%20the%20Foxes&l=227&n=&m="
amarok: [lastfm] onNowPlayingReturn: [id: 0 ] "OK"
BEGIN: void Scrobbler::onSubmissionReturn(const QString&)
"[id:"
"0"
"]"
"OK"
BEGIN: void ScrobblerManager::onScrobbled(const QList<TrackInfo>&)
"1"
"tracks were successfully scrobbled"
amarok: [lastfm] 1 toremove count: 1
amarok: [lastfm] Removing "The Rocket Summer – Do You Feel"
amarok: [lastfm] 0
amarok: [lastfm] "/home/ramblurr/.kde4/share/apps/amarok/outp0ur_submissions.xml" is now empty
END: void ScrobblerManager::onScrobbled(const QList<TrackInfo>&) [elapsed: 1 ms]
END: void Scrobbler::onSubmissionReturn(const QString&) [elapsed: 1 ms]
Any news on this? I've just tested this with current Amarok 2 trunk, and the result is (as Kevin said): 1) Works fine for local tracks. 2) Also works for Last.fm radio, but _only_ for the currently playing track. Former played tracks are not listed on the Last.fm site. Very odd... Can anyone verify if this works correctly with the official last.fm player? SVN commit 839619 by markey: Submit tracks to Last.fm correctly when playing Last.fm Radio. BUG: 164156 M +3 -1 ChangeLog M +8 -0 src/browsers/servicebrowser/lastfm/ScrobblerAdapter.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=839619 Unfortunately, this isnt fixed. I get this in my console output: BEGIN: void Scrobbler::onSubmissionReturn(const QString&) "[id:" "0" "]" "FAILED Plugin bug: Not all request variables are set - Invalid Rating and Source combination" amarok: [lastfm] Scrobbler HTTP error: 0 amarok: [lastfm] Scrobbler hard failure. Retrying in 30 seconds. END: void Scrobbler::onSubmissionReturn(const QString&) [elapsed: 1 ms] (I have about 50 songs in the queue which are about to be send). Tried to delete *submissions.xml a few times, didnt help either. Confirmed by leinir and eean. got it too with the same output Apparently setting a track to "love track" is the cause of this. apparently this markup is causing the problems : <userActionFlags>2</userActionFlags> if it's set to 0 that means no action, the track is submitted correctly but if it's set to 1 (the user skips the track) or 2 (the user loves the track) lastfm seems not to know how to handle it and prevents the submission. *** Bug 169760 has been marked as a duplicate of this bug. *** Can confirm that, tracked it down to loving tracks, too. Now we need someone who fixes it :) works fine for me when scrobbling loved local tracks. i think the issue here is when you try to submit tracks that you have loved/skipped/banned and are also from last.fm radio. ok, tracked it down to use not including the " the 5-digit Last.fm recommendation " , and the "key must be appended to this source ID to prove the validity of the submission (for example, "o[0]=L1b48a")." (from the API docs.) as we're using a now-ancient version of the official last.fm client code, we need to update that, and that depends on mxcl giving us the new modularized code that last.fm developed. *** Bug 169554 has been marked as a duplicate of this bug. *** Some news: We're in the process of switching the a new last.fm library, which might well solve this issue. But we're going to do this only after Beta2 is released, as we do not want to risk regressions. Bear with us :) Since Beta 3 is not far, any progress on this? Likely delayed until after beta 3. Stay tuned. SVN commit 877693 by lfranchi: new last.fm code for the last.fm service. basically, this replaces our old last.fm code drop from the 1.4 client with the new modular liblastfm from max at last.fm. currently the library is included here in-source, and we are compiling it as a lib and linking to it internally. as soon as they can, last.fm will release it as liblastfm, and amarok will depend on it. for now, and 2.0, this will stay in-source. note that i include a FindLibLastFm.cmake that is not being used, as soon as we switch to the external lib we can just switch to searching for the external lib w/ no hassle. NOTE: *please* test. i've tried to stress it as much as i can, but i can't think of all the edge cases. break it! this should fix a number of bugs with the old client. there is 1 bug that i know of with this code, and i have email max. BUG: 164156 BUG: 157296 BUG: 155197 BUG: 154904 BUG: 170816 |