Summary: | New Option: Hide tree branch lines | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | Josh Berry <des> |
Component: | style | Assignee: | Camilla Boemann <cbo> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | adds the option |
Description
Josh Berry
2008-06-11 08:21:27 UTC
Do you know of any other style that can do this, because i think it is impossible I know for a fact it was possible in Qt3, as some KDE3 styles (e.g. Baghira) had that option. I will investigate and see if any KDE4 styles have the option. Just two quick notes: 1) even if some style are able to do it with an ugly hack, doesn't mean we will do it too 2) I've not decided yet if this is something we would even want in oxygen Just so you don't get your hopes up :/ Here is a trivial patch against kdebase trunk that permanently disables tree branch lines in oxygen. I hope this addresses your point #1: Index: runtime/kstyles/oxygen/oxygen.cpp =================================================================== --- runtime/kstyles/oxygen/oxygen.cpp (revision 842651) +++ runtime/kstyles/oxygen/oxygen.cpp (working copy) @@ -1670,7 +1670,7 @@ //### FIXME: set sane color. QBrush brush(Qt::Dense4Pattern); brush.setColor(pal.mid().color() ); - p->fillRect(r, brush); + //p->fillRect(r, brush); return; } case Tree::ExpanderOpen: I did this in about 5 minutes, so it's obviously a proof-of-concept, but I'd be happy to clean it up, make an option, etc. (I'm not that familiar with Qt programming, so if you or someone else wouldn't mind answering questions, that would be helpful.) As to your point #2, I'm honestly perplexed as to why you wouldn't want it. All I'm proposing is to make it an option, and leave branch lines on by default. That way everyone's happy. Oxygen has very few options to begin with, so I don't think adding one more would clutter or confuse things. Thanks - I'd never had guessed it was that easy. As for if we will do it or not - I just warned you that we haven't talked/decided about it yet. It doesn't mean we won't do it. The reason we might not want it is that we don't want anything that conflicts with the artistic direction called oxygen. That doesn't mean we won't have an option or do it default as you suggest, but it could be. stay tuned, and thanks again Has there been any further discussion on this option? Created attachment 28051 [details]
adds the option
Here's a patch which hasn't been discussed yet... Adding an option is not exactly easy: you have to add about 12 lines somewhere in the code, so IMHO the design should be improved before adding any new options.
Sorry it took so long to get to this. I've applied the patch to my checkout, and from a purely end-user perspective, it looks good. I'd love to see this checked in. Thanks! What is the status of this? I know it's not going to make it into 4.2, but will it be slated for 4.3? Well, 4.2 has come and gone, and still no word. I've been using this patch for quite some time now, with no noticeable problems. Can it be committed for 4.3? Thanks. Ok I've talked to pinheiro - It will go into 4.3 :) as an option Great, many thanks! SVN commit 912670 by huynhhuu: New Option: Hide tree branch lines BUG: 163761 M +9 -1 config/oxygenconf.cpp M +2 -0 config/oxygenconf.h M +8 -4 oxygen.cpp M +1 -0 oxygen.h WebSVN link: http://websvn.kde.org/?view=rev&revision=912670 Great, thanks for checking this in! I'm looking forward to seeing it in my next update. |