Bug 163549

Summary:	discard unsaved changes: provide consistent buttons names & order
Product:	[Applications] systemsettings	Reporter:	Maciej Pilichowski <bluedzins>
Component:	general	Assignee:	System Settings Bugs <sourtooth+ssbugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	andresbajotierra
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	save-apply

Description Maciej Pilichowski 2008-06-08 20:22:21 UTC

Version:            (using KDE 4.0.4)
Installed from:    SuSE RPMs

This is a fork of:
http://bugs.kde.org/show_bug.cgi?id=163511

Christophe posted a screenshot of the latest version of this dialog (thank you):
http://bugs.kde.org/attachment.cgi?id=25213&action=view

The problem is:
* save -- please rename it to apply, one less term introduced, the better, especially it could suggest you save something to disk
* there is a problem with order -- it is reversed compared to SS, so either reverse it here, or in SS, but anyway, keep it consistent

Comment 1 Maciej Pilichowski 2008-11-17 15:58:43 UTC

Besides, dialog asks "do you want to apply..." and the answer is "save". In the SS there is no "save", but "apply".

See ss.

Comment 2 Maciej Pilichowski 2008-11-17 15:59:17 UTC

Created attachment 28628 [details]
save-apply

Comment 3 Dario Andres 2009-04-10 21:38:21 UTC

SVN commit 952056 by darioandres:

Rename "Save" to "Apply" on the "Unsaved Changes" dialog to keep consistency with SystemSettings buttons
(Also use an "Apply" button instead of a "Save" one)

CCBUG: 163549


 M  +3 -3      kcmultiwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=952056

Comment 4 Dario Andres 2009-04-10 21:39:37 UTC

Naming changes accepted. 
Button layout order needs discussing on #usability.
I can't backport this to 4.2.x as it will break the string freeze.
Thanks

Comment 5 Christoph Feck 2009-12-02 13:19:28 UTC

In current trunk, the Button order is: "Apply, Discard, Cancel", which is the correct (and fixed) order. Haven't looked which commit changed that, probably the KDE 4.3 System Settings rewrite.