Bug 162905

Summary:	form widgets with transparent background have no borders in Oxygen style
Product:	[Applications] konqueror	Reporter:	Germain Garand <germain>
Component:	khtml	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	aiacovitti, andresbajotierra, hugo.pereira.da.costa
Priority:	NOR
Version First Reported In:	4.10.2
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	testcase

Description Germain Garand 2008-05-30 18:13:32 UTC

Version:           4.0 (using Devel)
Installed from:    Compiled sources

some form widgets (linedits and buttons) have invisible border in Oxygen style when their background-color is set to transparent.

some of the colour changes in RenderWidget::updateFromElement are probably wrong.

Need to determine which, making sure background-color:transparent still works in other widget styles.

Comment 1 Dario Andres 2008-12-21 00:55:50 UTC

Can you still reproduce this bug with a recent KDE version? (4.1.3 / 4.2beta2 / 4.2svn) ?  Thanks :)

Comment 2 Andrea Iacovitti 2013-05-05 14:37:02 UTC

Created attachment 79717 [details]
testcase

It seems only the button alike widgets (pushButton, comboBox, checkBox, radioButton) have this problem.
The lineEdit in the testcase do have visible borders and transparent background, while buttons become visible (they show a "focus rect") only while hovering with mouse.
When a transparent background is specified in the style, the code in RenderWidget::updateFromElement basically does:
palette.setColor(QPalette::Base,QColor(0,0,0,0));   for lineedit
palette.setColor(QPalette::Button,QColor(0,0,0,0));   for buttons
In other styles i tested (i.e. plastique, windows, cleanlooks) borders are drawn, so i think it depends on how oxygen draws things and i'm not sure it can be solved by playing with the color palette.

Comment 3 Andrea Iacovitti 2013-05-05 18:20:56 UTC

Git commit c0daa108d8f6935d4e451e3f3ec3ecbdf5a5944f by Andrea Iacovitti.
Committed on 05/05/2013 at 19:38.
Pushed by aiacovitti into branch 'KDE/4.10'.

Do no set transparent background for checkBox and radioButton
unless they have a background image to show.
Otherwise, when using oxygen style, they could end up to be
invisible (as for the "Remember me" checkBox in twitter).

M  +11   -3    khtml/rendering/render_replaced.cpp

http://commits.kde.org/kdelibs/c0daa108d8f6935d4e451e3f3ec3ecbdf5a5944f

Comment 4 Christoph Cullmann 2024-05-06 18:38:49 UTC

Dear user,

KHTML (and KJS) was a long time more or less unmaintained and got removed in KF6.

Please migrate to use a QWebEngine based HTML component.

We will do no further fixes or improvements to the KF5 branches of these components beside important security fixes.

For security issues, please see:

https://kde.org/info/security/

Sorry that we did not fix this issue during the life-time of KHTML.

Greetings
Christoph Cullmann