| Summary: | digikam crashes when using light table (page down) | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Mark Purcell <msp> |
| Component: | LightTable-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | 0.9.4 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.4 | |
| Attachments: |
back trace from light table crash.
lighttable-crash.png quick fix new patch third patch |
||
|
Description
Mark Purcell
2008-05-29 15:13:24 UTC
Arnd, What do you think about ? Gilles I can't confirm this... light table works just fine here (I'm also using beta5). Thanks Andy. Same for me. i cannot reproduce the crash here... Gilles I can't reproduce that problem either,
and the above backtrace does not really help, right?
Mark, you wrote:
> I also noticed there are a couple of light table crash reports,
> that were never resolved.
I don't see any open crash reports for the light-table, did I miss one?
(It might be that a couple of crash reports had to be closed, because
those crashes were not reproducible and no back-trace with further information
was available).
Of course it might very well be possible that in certain
situtations one can trigger a crash, so a full back trace
in such a case would be very helpful!
Best, Arnd
Arnd,
> I don't see any open crash reports for the light-table, did I miss one?
> (It might be that a couple of crash reports had to be closed, because
> those crashes were not reproducible and no back-trace with further
> information was available).
Sorry, yes I was referring to those that were closed without a back-trace.
I'll try and generate the backtrack from -beta5 to be of more use.
Mark
Created attachment 25002 [details]
back trace from light table crash.
Mark, ==> #5 0x0fd4633c in Digikam::ThumbBarItem::next (this=0x0) "This" is null. this is why LT crash. Can you give us exactly all steps done on gui to reproduce it ? Gilles Caulier On Fri, 30 May 2008, Gilles Caulier wrote: > ==> #5 0x0fd4633c in Digikam::ThumbBarItem::next (this=0x0) > > "This" is null. this is why LT crash. > > Can you give us exactly all steps done on gui to reproduce it ? Gilles, I can reproduce using the following steps. 1. Load three images onto the light table 2. Drag the right hand image onto the left and right panes (or Ctrl+L, Ctrl+R) 3. Right click the right hand image and select "Remove Item" (or Ctrl+K) 4. Digikam crash (this=0x0) Attached screen shot just prior to crash. Mark Created an attachment (id=25005) lighttable-crash.png Mark, Arnd, Andy, Yes, now i can reproduce the crash... Who want to check source code (:=))) ? Gilles Ok, now I can confirm it, too. Maybe I'll take a look at the code later on, right now I'm too busy. It seems to crash only if the last image is displayed in the left and right window, otherwise the image will be just removed from the list as expected. Created attachment 25010 [details]
quick fix
Created attachment 25011 [details]
new patch
I think it is more logical to display the last image in the thumbar than the
first one
Created attachment 25012 [details]
third patch
When just two images were in the thumbbar and the last one was removed, no
image was displayed in the panel. Now the only remaining image is displayed in
the left panel.
SVN commit 815897 by aclemens: digiKam from KDE3 branch: fixed null-pointer issue when removing the last item in lighttable thumbbar CCBUGS: 162814 TODO: KDE4PORT M +2 -1 NEWS M +16 -5 utilities/lighttable/lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=815897 *** Bug has been marked as fixed ***. SVN commit 816103 by cgilles: backport commit #815897 from KDE3 branch CCBUGS: 162814 M +18 -8 lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=816103 SVN commit 827415 by aclemens: If only one image is left in thumbbar and it is removed from the list, lighttable crashes. Again this is the same nullpointer issue as mentioned in this bugreport and has been fixed now. CCBUGS:162814 M +0 -6 lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=827415 SVN commit 827429 by aclemens: backport commit #827415 from KDE3 branch CCBUGS: 162814 M +0 -6 lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=827429 |