Summary: | Sharpen slider enhancement refresh previews continuously | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Mark Purcell <msp> |
Component: | Plugin-Editor-Sharpen | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 0.9.4 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.9.4 | |
Sentry Crash Report: | |||
Attachments: | fixes continuous rendering of filter |
Description
Mark Purcell
2008-05-29 14:52:42 UTC
Yes, it is true, right now sharpening filter is unusable (and so is blur). Today I needed to scan some images and they all were too blurry. So I had to sharpen them a little bit, but every time I change a filter setting or try to zoom in, it is calculating. I always have to click abort immediately. The same for the blur filter (and maybe others, I have not checked yet). If you compare 'sharpening' with 'restoration', you can see the differences. I just changed the behavior of 'sharpen' to those of 'restoration'. I'll attach the patch. Created attachment 25992 [details]
fixes continuous rendering of filter
With this patch you can set your settings and hit "Try" to check them. Now it
is possible to zoom and change things like you want to...
This has to be applied for blur, too... and maybe other filters.
It is really a huge slowdown, right now I was not able to work with digiKam...
so I changed it immediately :-)
Gilles,
what do you think?
Andi, yes, patch is right, and of course, need to be backported to KDE4 Gilles Also the Abort button is enabled in every filter by default, but this is not true. I will disable it in CtrlDlg class. But I have to check first with every filter inherited from CtrlDlg... SVN commit 830068 by aclemens: backport commit #830067 from KDE3 branch CCBUGS:162812 M +3 -0 ctrlpaneldlg.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=830068 SVN commit 830084 by aclemens: added "Try" button to this filter dialog to avoid filter rendering on every settings change or zoom action. M +289 -319 imageeffect_sharpen.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=830084 SVN commit 830090 by aclemens: backport commit #830084 from KDE3 branch CCBUGS:162812 M +288 -318 imageeffect_sharpen.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=830090 I will add this behavior to all the other filters depending on CtrlPanelDlg as well: blurfx infrared oilpaint texture charcoal filmgrain emboss restoration noise reduction hotpixels blur |