Bug 162374

Summary:	incoming file transfer dialog steals focus from chat windows
Product:	[Unmaintained] kopete	Reporter:	Lucas Vinicius Hartmann <lucas.hartmann>
Component:	general	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	0.12.7
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Sample screenshot of effect

Description Lucas Vinicius Hartmann 2008-05-20 21:01:04 UTC

Version:           0.12.7 (using 3.5.9, Kubuntu (hardy) 4:3.5.9-0ubuntu7.1)
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.24-16-generic

If while typing a message a file is sent tou you, the incoming-file dialog will steal the focus from the dialog window.

This is pretty anoying if you type looking at the keyboard, and half the message ends up in the filename of the dialog...

Comment 1 Nadine van der Heijden 2008-07-08 17:45:39 UTC

can you provide a screenshot?

Comment 2 Lucas Vinicius Hartmann 2008-07-08 19:56:34 UTC

I just realized how confuse the explanation was...

The focus is stolen by the file save dialog, from the CHAT window...

Comment 3 Lucas Vinicius Hartmann 2008-07-08 19:59:35 UTC

Created attachment 25947 [details]
Sample screenshot of effect

Focus stolen: (HALF TH)E MESSAGE on the chat window, and HALF TH(E MESSAGE) on
the file name...

Comment 4 Kai Becker 2008-07-20 14:20:02 UTC

Tested with KDE 4.0.99

Dialog still steals Focus, but filename is not overwritten.

Comment 5 Michael 2008-07-22 13:52:32 UTC

Incoming file transfer dialog still steals focus and input, but the default field is now the accept button, so the filename isnt overwritten, tested with svn trunk r835161.

That leads to the problem that if you hit the space bar, you accept that transfer.

Also maybe worth to note that focus stealing is something kwin can deal with, see the option "focus stealing prevention".

Comment 6 Roman Jarosz 2008-08-26 08:43:44 UTC

SVN commit 852546 by rjarosz:

Add incoming file transfer request into chat window and remove the old dialog.
Add globally unique id into Kopete::Message.
Add defualt incoming file transfer request style to make it work with all styles.

File transfer request look can be changed with Incoming/FileTransferRequest.html in \
chat style. Supported style tags are: fileName, fileSize, fileIconPath, \
saveFileHandlerId, saveFileAsHandlerId, cancelRequestHandlerId Save, save as and \
cancel buttons have to have id="%saveFileHandlerId%", id="%saveFileAsHandlerId%", \
id="%cancelRequestHandlerId%".

For now we don't support Adium style because they require JavaScript (security \
problem).

BUG: 129577
BUG: 162374
BUG: 135785
CCBUG: 137253



 M  +180 -24   kopete/chatwindow/chatmessagepart.cpp  
 M  +6 -1      kopete/chatwindow/chatmessagepart.h  
 M  +42 -1     kopete/chatwindow/kopetechatwindowstyle.cpp  
 M  +3 -1      kopete/chatwindow/kopetechatwindowstyle.h  
 M  +0 -4      libkopete/CMakeLists.txt  
 M  +94 -5     libkopete/kopetemessage.cpp  
 M  +66 -3     libkopete/kopetemessage.h  
 M  +92 -28    libkopete/kopetetransfermanager.cpp  
 M  +27 -6     libkopete/kopetetransfermanager.h  
 D             libkopete/ui/fileconfirmbase.ui  
 D             libkopete/ui/kopetefileconfirmdialog.cpp  
 D             libkopete/ui/kopetefileconfirmdialog.h