| Summary: | Recognize SLiM as login manager and activate "shutdown" and "reboot" options. | ||
|---|---|---|---|
| Product: | [Plasma] ksmserver | Reporter: | DrSlony <bugs> |
| Component: | general | Assignee: | Lubos Lunak <l.lunak> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | wishlist | CC: | mail, see.kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
DrSlony
2008-05-18 15:46:38 UTC
Bump Now, I'm not a KDE dev but I took a look at ksmserver's code. What the code does now is: - check if the offerShutdown setting is enabled (enabling it by default) - check if KDM allows shutdown The actual shutdown code checks these things too, and has special handling when shutdown is requested even though KDM or the offerShutdown setting do not "allow" it. From this, a few remarks: - right now, the offerShutdown setting seems useless, it looks to me as an exact duplicate of KDM's "Allow shutdown" setting. - it sure does not work the way anyone would expect it to: enabling the "Offer shutdown options" setting does *not* make KDE offer shutdown options in several cases. - ksmserver already seems to handle shutdown when KDM is not present. And a few solutions I see: - in KSMServer::canShutdown() return true if offerShutdown is enabled, and KDM allows shutdown OR if the login manager is not KDM. - always disable and grey out "Offer shutdown options" if KDM does not allow shutdown or if the login manager is not KDM. - remove "Offer shutdown options" altogether and just use KDisplayManager.canShutdown(). Of course, the first one seems best to me. In the current state of things this looks more like a bug than a wish, to me. ftr, much of what was said in bug 186198 applies here as well. Abandoning it. |