Bug 161816

Summary:	strange popup in channel list
Product:	[Applications] konversation	Reporter:	Pino Toscano <pino>
Component:	general	Assignee:	Konversation Developers <konversation-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	wordsizzle
Priority:	NOR
Version:	1.0.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Channel List context menu patch Channel List context menu patch

Description Pino Toscano 2008-05-08 21:33:04 UTC

Version:           1.0.1 (using 3.5.9, Debian Package 4:3.5.9.dfsg.1-2+b1 (lenny/sid))
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.24-1-amd64

When right-clicking on an item in a channel list, the popup menu that appears is quite... strange.
Its title was "Open URLs", and it had a single disabled item "<< No URL found>>". This puzzled me a bit.
Trying on another channel made me realize (thanks Eike as well) that it lists the URLs in the topic of the selected channels as items.
Though, I am not really sure that this is the expected behaviour. (At least, IMHO.)
It should at least have "Join channel" as first item, and then (after a menu separator, or maybe in a submenu?) all the URLs in the topic of the selected channel.
Then the title should be different as well, most probably the channel name itself, or even no title at all.

Comment 1 Anselmo L. S. Melo (anselmolsm) 2009-07-15 07:00:56 UTC

Created attachment 35341 [details]
Channel List context menu patch

The patch attached includes the 'Join Channel' option to the context menu + separator + open URLs as a submenu, disabled if there's no URL to show.

Comment 2 Travis McHenry 2009-07-15 11:23:11 UTC

Patch looks good thanks, but I'm taking the time to rewrite channellistpanel.cpp away from k3listview towards a .ui and get rid of some ridiculous connects.

So barring any unforeseen difficulties the patch + rewrite should be in by tomorrow or the next dayish.

Comment 3 Anselmo L. S. Melo (anselmolsm) 2009-07-15 13:17:24 UTC

Created attachment 35348 [details]
Channel List context menu patch

(In reply to comment #2)

Nice!

BTW, I found a bug in the patch I sent yesterday =)... I'm reposting it, just in case.

Comment 4 Travis McHenry 2009-07-17 02:41:35 UTC

SVN commit 998141 by tjmchenry:

Give the channel list some much needed love
Port it to QTreeWidget and to a .ui
Added a 'Channel List Buffer' progress bar to give user feedback on refresh list progress

Apply patch to add join channel to context menu thanks to anselmolsm
BUG:161816

Use irc-* join channel icon in the ircview context menu.
CCBUG:193211

 M  +9 -1      CMakeLists.txt  
 M  +166 -355  irc/channellistpanel.cpp  
 M  +23 -81    irc/channellistpanel.h  
 A             irc/channellistpanelui.ui  
 D             irc/channellistviewitem.cpp  
 D             irc/channellistviewitem.h  
 M  +6 -1      viewer/ircview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=998141