Bug 161638

Summary: Game ends despite another match
Product: [Applications] kshisen Reporter: Markus Elfring <Markus.Elfring>
Component: generalAssignee: Dave Corrie <kde>
Status: CONFIRMED ---    
Severity: normal CC: davidrsweet, dothebart, finex, GeoBaltz, schwarzer, tricotvanille2003, wolsonjr
Priority: NOR    
Version First Reported In: 1.6.0   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: excerpt from a screenshot
Screen shot of stuck game with valid move remaining.
attachment-15502-0.html

Description Markus Elfring 2008-05-04 22:38:48 UTC
Version:           1.6.0 (using KDE 4.0.3)
Installed from:    SuSE RPMs
OS:                Linux

It seems that I have noticed a issue that was reported for previous releases already.
Bug #37132: no more moves error
Bug #34104: solvable game: No more moves?
Comment 1 Markus Elfring 2008-05-04 22:47:18 UTC
Created attachment 24631 [details]
excerpt from a screenshot

The end of game is displayed despite there is still a pair of green "M/W cards
left.
Comment 2 George Baltz 2012-02-12 18:30:10 UTC
Created attachment 68733 [details]
Screen shot of stuck game with valid move remaining.
Comment 3 George Baltz 2012-02-12 18:31:08 UTC
Still a problem with current version (1.8.3).
Comment 4 Frederik Schwarzer 2014-08-29 20:18:37 UTC
*** Bug 338110 has been marked as a duplicate of this bug. ***
Comment 5 Frederik Schwarzer 2014-08-29 20:20:08 UTC
*** Bug 336640 has been marked as a duplicate of this bug. ***
Comment 6 Frederik Schwarzer 2014-08-29 20:20:56 UTC
*** Bug 338635 has been marked as a duplicate of this bug. ***
Comment 7 Frederik Schwarzer 2014-08-29 20:24:58 UTC
Ok, so apparently this has been a problem for a long time but now comes up very frequently. Interesting.

That part of the code I never really dug in when I adopted the game, so I currenty do not understand what might go wrong there.

I put some debug stuff in my local copy of the game and am currently trying to reproduce the problem.

In any way, thank you all for your reports. I hope I can find the cause of the issue soon. :)
Comment 8 Frederik Schwarzer 2014-08-31 16:21:09 UTC
I am still not able to reproduce the issue.

Can you please post here your settings? You can find those in the settings dialog under
"Settings -> Configure Shisen-Sho..."

Gravity:
Solvable games only:
Chinese style:
Tiles can slide:
Difficulty:
Removal speed:
Board size:


Thanks
Comment 9 Markus Elfring 2014-08-31 16:40:55 UTC
(In reply to Frederik Schwarzer from comment #8)

I do not see how these settings would influence the card matching process.
Was the involved algorithm changed between the affected software releases?
Comment 10 Frederik Schwarzer 2014-08-31 19:11:12 UTC
(In reply to Markus Elfring from comment #9)
> I do not see how these settings would influence the card matching process.
> Was the involved algorithm changed between the affected software releases?

Since I cannot reproduce the issue with the same version, I might have other settings in game difficulty or chinese style matching. These at least influence the likelyhood of the issue occuring.

The matching code was not touched in at least five years.
Comment 11 Markus Elfring 2014-09-02 11:55:42 UTC
(In reply to Frederik Schwarzer from comment #10)

The gravity setting can also have an effect on the evolving card layout. Is it possible to save and restore a game situation anyhow?

Would it be useful to test this software application a bit more by let it "play" on itself eventually?
Comment 12 Frederik Schwarzer 2014-09-05 18:23:53 UTC
It is currently not possible to save a game state.

When compiled with debugging enabled (see debug.h) you can press 'h' (help) to remove matching tiles. This way, one game only takes a few seconds.

However, I have dome that about 50 times and could not see the issue you describe. That's why I ask for the settings you use.
Comment 13 Markus Elfring 2014-09-05 18:50:38 UTC
(In reply to Frederik Schwarzer from comment #12)
> It is currently not possible to save a game state.

A data excerpt can be represented by a raster image (e. g. screenshots).


> However, I have dome that about 50 times and could not see the issue you describe.

I find such manual testing inappropriate if a surprising game situation can not be exactly restored. Is there any OCR approach needed?
Comment 14 David Sweet 2014-09-05 22:08:09 UTC
Created attachment 88585 [details]
attachment-15502-0.html

Gravity is checked, all other configuration options are blank.

Difficulty is set to medium.

Piece removal speed is set to medium

board size is 24x12


On Fri, Sep 5, 2014 at 1:50 PM, Markus Elfring <Markus.Elfring@web.de>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=161638
>
> --- Comment #13 from Markus Elfring <Markus.Elfring@web.de> ---
> (In reply to Frederik Schwarzer from comment #12)
> > It is currently not possible to save a game state.
>
> A data excerpt can be represented by a raster image (e. g. screenshots).
>
>
> > However, I have dome that about 50 times and could not see the issue you
> describe.
>
> I find such manual testing inappropriate if a surprising game situation
> can not
> be exactly restored. Is there any OCR approach needed?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>
Comment 15 George Baltz 2014-09-08 14:59:06 UTC
My settings also only Gravity checked; difficulty: medium, removal speed:medium, size: 24x12.

A point from long ago - when the 'no more moves' had an OK button, if you clicked OK, you could continue playing.  The clock was stopped at the first message, so any following moves took no time!
Comment 16 tricotvanille2003 2022-12-03 00:44:19 UTC
Gravity: yes
Solvable games only: yes
Chinese style: yes
Tiles can slide: no
Difficulty: medium (centered cursor)
Removal speed: medium (centered cursor)
Board size: 24x16

I took a print screen of the result, if you need it. I can see at least 5 more moves available!
Comment 17 tricotvanille2003 2022-12-03 00:47:55 UTC
(In reply to tricotvanille2003 from comment #16)
> Gravity: yes
> Solvable games only: yes
> Chinese style: yes
> Tiles can slide: no
> Difficulty: medium (centered cursor)
> Removal speed: medium (centered cursor)
> Board size: 24x16
> 
> I took a print screen of the result, if you need it. I can see at least 5
> more moves available!

sorry, I missed a detail... my version is not on the list: Version 1.10+ #25
I'm under Linux Mint 20.3 64bits