Summary: | bug with crossfade between songs effect | ||
---|---|---|---|
Product: | [Applications] juk | Reporter: | Andrew Belitsky <belitsky.a> |
Component: | general | Assignee: | Michael Pyne <mpyne> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Andrew Belitsky
2008-04-22 18:42:47 UTC
SVN commit 809463 by mpyne: Improve crossfading in JuK 4.0 branch to not sound like a catastrophe for the first half second. I think the order of inserting effects into the audio path has something to do with it, so I've reordered everything to be ready before starting the next track. In addition you shouldn't get huge volume jumps when crossfading rapidly and I've improved the memory allocation lifetimes. Unfortunately you still sometimes get a bit of high-volume at the beginning of the next track but I don't think that is juk's fault. CCBUG:161168 M +120 -62 playermanager.cpp M +11 -3 playermanager.h WebSVN link: http://websvn.kde.org/?view=rev&revision=809463 SVN commit 809464 by mpyne: Improve crossfading in JuK trunk to not sound like a catastrophe for the first half second. I think the order of inserting effects into the audio path has something to do with it, so I've reordered everything to be ready before starting the next track. In addition you shouldn't get huge volume jumps when crossfading rapidly and I've improved the memory allocation lifetimes. Unfortunately you still sometimes get a bit of high-volume at the beginning of the next track but I don't think that is juk's fault. CCBUG:161168 M +120 -62 playermanager.cpp M +11 -3 playermanager.h WebSVN link: http://websvn.kde.org/?view=rev&revision=809464 SVN commit 820637 by mpyne: Really mostly fix bug 161168 (JuK crossfading is teh suck). We cache the VolumeFaderEffect object and include it in the pipeline at all times. What this does is allows the volume changing to go smoothly when we try to start changing the volume of our playing track. In addition phonon-gst crashes if I try to remove the fader effect afterwards and skips horribly if I don't cache the fader effect. Unfortunately phonon-xine suffers from crackling sounds with the fader effect left in the chain, so now phonon-gst is the best backend to use for JuK. Both sound much better during the fading process though, although phonon-xine still suffers from initial high volume on the incoming song. This pretty much works for me now though, so I'm closing the bug. BUG:161168 M +23 -43 playermanager.cpp M +2 -0 playermanager.h WebSVN link: http://websvn.kde.org/?view=rev&revision=820637 |