Bug 160885

Summary:	[PATCH] Verification of PGP signatures broken
Product:	[Unmaintained] kmail	Reporter:	Onno Molenkamp <onno>
Component:	encryption	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	SVN trunk (KDE 4)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Suggested fix for bug 160885

Description Onno Molenkamp 2008-04-16 00:11:43 UTC

Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          gcc version 4.2.1 (SUSE Linux) 
OS:                Linux

On every PGP-signed message, I'm getting an "Not enough information to check signature validity." message which expands to:

Message was signed with unknown key.
The validity of the signature cannot be verified.
Status: Error: Signature not verified

This is caused by gpg returning an error (verify signatures failed: Unknown system error) which is caused by kmail not passing any signature to it. It looks like this is caused by a change in kdepim/kmail/objecttreeparser.cpp in SVN revision 463791 (in 2005, shortly after 3.5 was branched!) that accidentally removed the line from ObjectTreeParser::writeOpaqueOrMultipartSignedData that set the variable signaturetext that is used later on in this method as a parameter to the actual verification method.

Comment 1 Onno Molenkamp 2008-04-16 00:13:16 UTC

Created attachment 24351 [details]
Suggested fix for bug 160885

Comment 2 Thomas McGuire 2008-05-02 18:31:33 UTC

This bug is fixed in trunk revision 803023.
See http://websvn.kde.org/?view=rev&revision=803023 .

Thanks for the patch, but the merge in that commit also fixed it.