Summary: | Try to check MD5 hash against one stored in MD5SUMS file (Burn CD Image dialogue) | ||
---|---|---|---|
Product: | [Applications] k3b | Reporter: | Jan Minář <rdancer> |
Component: | general | Assignee: | k3b developers <k3b> |
Status: | REPORTED --- | ||
Severity: | wishlist | CC: | rdancer |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
This patch shows how I think the MD5 hash checking should work. I'll need to work on it some more. Please comment.
Implements most functionality except manual checksum file selection. |
Description
Jan Minář
2008-04-09 06:23:23 UTC
Created attachment 24274 [details]
This patch shows how I think the MD5 hash checking should work. I'll need to work on it some more. Please comment.
This is the patch mentioned in the original report.
Created attachment 24296 [details]
Implements most functionality except manual checksum file selection.
Rewritten to use proper Qt/KDE/C++ constructs, and formatted to blend in with
the surrounding code. Few issues remain, are flagged out in comments. Manual
selection of checksum file not implemented, placeholder context menu item in
place . I'm quite happy with this version of the patch. Since the
development should really take place in CVS, this might be the last version for
1.0.4.
Still looking for comments.
Looks quite good. Two things though: * Please do not use "goto". I would really like to not have that in the K3b code. ;) * I think this could go into a new class. Something like ChecksumFileParser. This class could then provide a method to search for checksum files according to some pattern or an image filename and then also parse them. And: you are right. I won't add new features to the 1.0.x branch. KDE4 is the new target and the little time I use on K3b these days goes to the port. So it would be great if you could port the patch to KDE4. In any case: thanks a lot for working on this. I will gladly include it into K3b. Thanks for the comments. I am going to obviate the goto call, and refactor the code as a new class, and port to KDE4. Other things to do are marked with ``XXX'' and ``TODO'' throughout the code. I don't know how much time I'll be able to allocate to coding in the following few weeks, so don't expect any update anytime soon. Which doesn't mean I've abandoned this patch. Perfect. Thanks a lot again. |