Bug 160135

Summary:	Add a clear finished button
Product:	[Applications] kget	Reporter:	Arnout Boelens <a.m.p.boelens>
Component:	general	Assignee:	KGet authors <kget>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	finex
Priority:	NOR
Version:	2.0.2
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Clean all finished transfers action

Description Arnout Boelens 2008-03-31 00:08:57 UTC

Version:           2.0.2 (using 4.0.2 (KDE 4.0.2), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.24-1-686

Right now, all finished downloads are showing up in the list until you delete them. For when you are downloading a lot of files, it would be really convenient to have a "clear all finished" button, so you can delete files form the list without accidentally deleting files which are still downloading.

Comment 1 FiNeX 2008-03-31 10:31:22 UTC

This idea is good.

Comment 2 Javier goday 2008-04-09 12:06:25 UTC

Created attachment 24276 [details]
Clean all finished transfers action

Comment 3 Javier goday 2008-04-09 12:16:24 UTC

Attach a patch to implement the action 'clear finished transfers'
I use the icon edit-clear-list for the action, i don't know if it is the best choice ..

Comment 4 Lukas Appelhans 2008-04-09 12:37:38 UTC

Patch looks good imo :)
+1 for commiting :)

Lukas

Comment 5 FiNeX 2008-04-09 16:00:53 UTC

I'll test it when it will be applied :)

Comment 6 Javier goday 2008-04-12 16:05:12 UTC

SVN commit 796087 by jgoday:

- Add an action to clean all finished transfers
BUG:160135


 M  +13 -0     core/kget.cpp  
 M  +5 -0      core/kget.h  
 M  +15 -0     mainwindow.cpp  
 M  +1 -0      mainwindow.h  
 M  +1 -0      ui/kgetui.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=796087

Comment 7 FiNeX 2008-04-23 00:52:53 UTC

kget creash (without backtrace) using the action. (revision 799878)
I've got only this log on the shell:

kget(15464) Job::setPolicy: Job::setPolicy( 1 )
kget(15464) Scheduler::updateQueue: Scheduler: Evaluating job  0
kget(15464) ViewsContainer::showDownloadsWindow: ViewsContainer::showDownloadsWindow
kget(15464) transferMultiSegKio::stop:
kget(15464) TransferGroup::calculateDownloadLimit: "Now we are calculating download Limits =): 0"
kget(15464) TransferGroup::calculateDownloadLimit: We are supporting speedlimits =)
kget(15464) TransferGroupScheduler::calculateUploadLimit: 1
kget(15464) TransferGroup::calculateUploadLimit: Now we are calculating upload Limits =)
kget(15464) TransferGroup::calculateUploadLimit: We are supporting speedlimits =)
kget(15464) SQLiteStore::saveItem: "constraint failed Unable to fetch row"
kget(15464) TransferGroupScheduler::calculateDownloadLimit: "Adding downloadLimit for group My Downloads to pool"
kget(15464) TransferGroupScheduler::calculateUploadLimit: 1
kget(15464) TransferGroup::calculateSpeedLimits: *************************** HERE WE ARE
kget(15464) TransferGroup::calculateDownloadLimit: "Now we are calculating download Limits =): 0"
kget(15464) TransferGroup::calculateDownloadLimit: We are supporting speedlimits =)
kget(15464) TransferGroup::calculateUploadLimit: Now we are calculating upload Limits =)
kget(15464) TransferGroup::calculateUploadLimit: We are supporting speedlimits =)
kget(15464) TransferHandler::postDeleteEvent: TransferHandler::postDeleteEvent() ENTERING
kget(15464) TransferHandler::postDeleteEvent: TransferHandler::postDeleteEvent() LEAVING
kget(15464) TransferHandler::delObserver: TransferHandler: OBSERVERS-- =  1
ASSERT: "extenderIndices.value(extender).isValid()" in file /home/test/KDE4/kdesvn/kdelibs/kdeui/itemviews/kextendableitemdelegate.cpp, line 128






P.S: the kget toolbar should be configurable for adding/removing actions.

Comment 8 Urs Wolfer 2008-04-23 19:34:15 UTC

Your crash is related to #157436. It does not crash because of this new feature.

Comment 9 Lukas Appelhans 2008-04-23 20:13:18 UTC

You can already configure the toolbar actions via Settings->Configure Toolbar (free from German) :)

Lukas

Comment 10 FiNeX 2008-04-23 23:44:07 UTC

Thanks Urs & Lukas :-)