Bug 160063

Summary:	"Recently Plugged Devices" title hardcoded white
Product:	[Unmaintained] plasma4	Reporter:	Andrew Lake <jamboarder>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bcooksley
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Attachment That Shows Relapse In Bug Believed Fix, Altered Revision 820974 sourtooth's changes in proper patch format Proper patch

Description Andrew Lake 2008-03-29 17:02:02 UTC

Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

The device-notifier applet popup title text, "Recently Plugged Devices", is hard coded white. Therefore it is difficult to read with plasma themes that have a lighter background.

Steps to Reproduce:
1. Load the Aya Plasma theme
2. Select the default colorscheme in the Colors module of system settings.
3. Click on Device Notifier and notice text remains white.  Does not correct itself on restart.

A review of the source shows that the label is CSS hard-coded white.

Comment 1 Rafał Miłecki 2008-04-10 14:20:05 UTC

This was fixed by duffeck in commit http://websvn.kde.org/?view=rev&revision=792851

Comment 2 Rafał Miłecki 2008-04-10 14:22:56 UTC

*** Bug has been marked as fixed ***.

Comment 3 Ben Cooksley 2008-06-17 07:28:35 UTC

Created attachment 25395 [details]
Attachment That Shows Relapse In Bug

This Bug Has Regressed. Requesting Bug Be Reopened

Comment 4 Ben Cooksley 2008-06-17 07:29:37 UTC

FYI: Using KDE4Daily Rev 820990

Comment 5 Ben Cooksley 2008-06-17 08:00:04 UTC

Adding Self To CC, Also Additional Information:

Plasma Theme: Aya
Colour Theme: Oxygen

Additional Testing By Placing The Another Device Notifer Applet On The Desktop Has Revealed That It Then Sets The Text Colour Correctly, Until The Plasma Theme Is Changed. When The Plasma Theme Is Changed The Text Colour DOES NOT Update Itself.

This Is A Different Bug, Should I Create A New Bug?

Comment 6 Ben Cooksley 2008-06-17 08:58:50 UTC

Created attachment 25396 [details]
Believed Fix, Altered Revision 820974

Patch, But Not In Patch Format, Complete File
Can't Compile / Test But This Should Work As Far As I Know.

What I Did: Created Slot At Bottom Of File, Just Above #include
"devicenotifier.moc" Called updateColors()

Connected That At The Bottom Of init()

If You Can't See The Differences.

If It's Fine, Please Commit, As I Don't Have A SVN Account

Comment 7 Markus Mauder 2008-06-17 10:25:08 UTC

Created attachment 25397 [details]
sourtooth's changes in proper patch format

Turned sourtooth's proposed changes into a patch for easier review. Not able to
test either, currently on the road, sorry.

original description:
"Believed Fix, Altered Revision 820974

Patch, But Not In Patch Format, Complete File
Can't Compile / Test But This Should Work As Far As I Know.

What I Did: Created Slot At Bottom Of File, Just Above #include
"devicenotifier.moc" Called updateColors()

Connected That At The Bottom Of init()

If You Can't See The Differences.

If It's Fine, Please Commit, As I Don't Have A SVN Account "

Comment 8 Anne-Marie Mahfouf 2008-06-17 17:08:28 UTC

Created attachment 25413 [details]
Proper patch

This is the proper patch for allowing change of theme

Comment 9 Anne-Marie Mahfouf 2008-06-17 17:14:03 UTC

SVN commit 821474 by annma:

let the applet adapt to theme change - please guys test and comment, thanks!

CCBUG=160063


 M  +12 -4     devicenotifier.cpp  
 M  +2 -0      devicenotifier.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=821474