| Summary: | does not correctly use the file: "panel-background.svg" | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | James Richard Tyrer <tyrerj> |
| Component: | panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Current SVG file for Panel background
"panel-background.svg" with square ends. corrected "panel-background.svg" file that works in all positions and lengts |
||
|
Description
James Richard Tyrer
2008-03-27 23:39:06 UTC
Created attachment 24096 [details]
Current SVG file for Panel background
no, it doesn't *have* ends because it takes the full width/height of the screen. if there were ends, they would be offscreen where you wouldn't see them. support for non-full-width panels will come eventually. When the Panel functions properly so that its length can be varied, then it will have ends. So, the original code was correct and what the ends look like should be determined by the SVG file. As it is, the Panel is violating the standards for Plasma themes. Created attachment 24097 [details]
"panel-background.svg" with square ends.
There is perhaps an issue with how wide the "left" and " right" objects should
be.
Created attachment 24143 [details]
corrected
Actually this won't work either since the Panel needs to be correctly themed in
all 4 positions.
it's optional to be themed in all 4 positions, you can also just have a symmetrical design that works on all positions. the 4 theming system only matters if your light source direction needs to change as well. anyways, the panel code is indeed correct. we don't do end caps on screen edges, due to margins and fitts law. it is arguable that on no margin designs we should show the edges, however that means we behave differently depending on that hint, and we'd like to keep the consistency instead. I appear to have misunderstood the problem that I was having trying to change the Panel theme. The code in Trunk does appear to handle this correctly using the length without ends so that the ends disappear when the panel is full width. The problem actually appears to be the the file "panel-background.svg" which was only designed for a bottom Panel and does not produce a correct boarder in the other positions. Created attachment 24151 [details]
"panel-background.svg" file that works in all positions and lengts
This works for me. If OK, please commit.
this was actually reported in another BR which is now in the oxygen product iirc. anyways, you have an svn account, correct? (i see in the accounts list still.) the change to the svg looks fine, so if you'd like you can commit it (always nicer to let the individual who does the fix commit it =) if for some reason can't, let me know. SVN commit 792768 by tyrerj: CCBUG: 159981 "Default" style Panel Backgroung SVG file modified to have the same boarder on all 4 sides so that it has a boarder when used in all 4 edges of the screen. M +170 -365 panel-background.svg WebSVN link: http://websvn.kde.org/?view=rev&revision=792768 r792769 | tyrerj | 2008-04-01 20:09:33 -0700 (Tue, 01 Apr 2008) | 3 lines BUG: 159981 Revision 792768 backported to Branch. |