Bug 159584

Summary:	File-transfer is always "canceled" in Yahoo!
Product:	[Unmaintained] kopete	Reporter:	mi+kde
Component:	Yahoo Plugin	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mboquien
Priority:	NOR
Version First Reported In:	0.12.7
Target Milestone:	---
Platform:	unspecified
OS:	FreeBSD
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description mi+kde 2008-03-20 00:12:48 UTC

Version:           0.12.7 (using 3.5.9, compiled sources)
Compiler:          Target: amd64-undermydesk-freebsd
OS:                FreeBSD (amd64) release 7.0-STABLE

So far I have never been able to receive a file from a Yahoo! contact. The dialog pops up, I type a new for the file (why is not there a default?) and hit "Accept".

The progress=bar appears for a short time and then I get a notice, that the sender has canceled the transmission, which is not true, of course.

The file-size is presented as 0, BTW...

Comment 1 Matt Rogers 2009-03-20 14:01:26 UTC

SVN commit 941719 by mattr:

Yahoo File Transfer fixups by John Groszko

Recieving works, but sending doesn't so far.

From the review request:

I'm trying to get Yahoo File Transfers working again, but I've gotten to
a point where I need input from someone with a fresh set of eyes or more
brains than me.

Receiving files works, but sending files does not. About 10k into the
transfer I see an unknown error code 16, and wireshark shows a bunch of
TCP Duplicate ACKs. The error looks like this in the debug log:

kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData:
read: 1024  written:  1024
kopete(6494)/kopete (yahoo)
YahooAccount::slotFileTransferBytesProcessed: Transfer:  2  Bytes: 10240
kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData:
kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::connectFailed:
16 :  "an unknown/unexpected error has happened"

Some input/insight would be awesome, since I'd like to get this working
again...

Thanks for the patch John!
CCBUG: 159584

 M  +4 -3      filetransfernotifiertask.cpp  
 M  +6 -7      logintask.cpp  
 M  +169 -25   sendfiletask.cpp  
 M  +16 -1     sendfiletask.h  
 M  +2 -2      yahootypes.h  
 M  +4 -0      ymsgprotocol.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=941719

Comment 2 Matt Rogers 2009-03-20 17:02:07 UTC

SVN commit 941875 by mattr:

Yahoo File Transfer fixups by John Groszko

Recieving works, but sending doesn't so far.

From the review request:

I'm trying to get Yahoo File Transfers working again, but I've gotten to
a point where I need input from someone with a fresh set of eyes or more
brains than me.

Receiving files works, but sending files does not. About 10k into the
transfer I see an unknown error code 16, and wireshark shows a bunch of
TCP Duplicate ACKs. The error looks like this in the debug log:

kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData:
read: 1024  written:  1024
kopete(6494)/kopete (yahoo)
YahooAccount::slotFileTransferBytesProcessed: Transfer:  2  Bytes: 10240
kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData:
kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::connectFailed:
16 :  "an unknown/unexpected error has happened"

Some input/insight would be awesome, since I'd like to get this working
again...

Thanks for the patch John!
BUG: 159584

 M  +4 -3      filetransfernotifiertask.cpp  
 M  +6 -7      logintask.cpp  
 M  +169 -25   sendfiletask.cpp  
 M  +16 -1     sendfiletask.h  
 M  +2 -2      yahootypes.h  
 M  +4 -0      ymsgprotocol.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=941875