Bug 158825

Summary: Batch image resizing doesn't use the measures provided
Product: [Applications] digikam Reporter: Anders Lund <anderslund>
Component: Plugin-Bqm-ResizeAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: imaging-bugs-null, languitar
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.8.0
Sentry Crash Report:
Attachments: Fixes rounding errors for resize 1dim

Description Anders Lund 2008-03-05 21:54:02 UTC 
Version:           0.9.2-final (using 3.5.9, Kubuntu (gutsy) 4:3.5.9-0ubuntu1~gutsy1~ppa1)
Compiler:          Target: x86_64-linux-gnu
OS:                Linux (x86_64) release 2.6.22-14-generic

When batch resizing images, digikam does not respect my sizes, for example setting the size in the batch resizer to 640 results in images with a width of 639.
Comment 1 Johannes Wienke 2009-10-01 14:39:18 UTC 
This seems still to be valid. I will try to fix it.
Comment 2 Johannes Wienke 2009-10-01 15:11:16 UTC 
Created attachment 37297 [details]
Fixes rounding errors for resize 1dim

This fixes the problem but I think there is more refactoring needed for that tool. The main problem I see, is that the method ResizeImage mirrors capabilities that imagemagick supports directly via the command line. The size error here was caused by different roundings. I think we should remove ResizeImage completely, as everything it does with the sizes can be done by imagemagick directly. The only thing that lasts is the calculation if the image size is increased or not. This is currently used to "switch on" the selected filter. But that's not really switching it on, it's just overriding the default provided by imagemagick. So my proposal would be to add a <default> entry in the filter list. If this entry is selected, no filter options is passed to imagemagick. Then ResizeImage can be removed completely as far as I can see. Would that be an option?
Comment 3 Johannes Wienke 2009-10-01 18:54:50 UTC 
Seems I kicked this from the list by assigning it to me.

Can someone commit these changes as I still don't have an svn account?
Comment 4 caulier.gilles 2009-10-01 19:41:05 UTC 
SVN commit 1030146 by cgilles:

apply patch #37297 from Johannes Wienke
BUGS: 158825


 M  +9 -2      resizeimagesdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1030146