| Summary: | Gwenview does not support image files in RAW format | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Thomas Damgaard <thomasdn> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | agateau, deepak, kdebug, romain.pub, sine.nomine |
| Priority: | NOR | ||
| Version: | 1.4.1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/gwenview/97d250f3d2c40766e154fac15bf25a8ecdbad879 | Version Fixed In: | 4.13.0 |
| Sentry Crash Report: | |||
| Attachments: | proposed patch (just basic stuff, further work needed) | ||
|
Description
Thomas Damgaard
2008-03-05 09:46:25 UTC
I see your point, but I believe this is outside of Gwenview scope for now. Gwenview main audience is not professional photographers. If you need RAW file support, you probably should use an application like Digikam. Hm, not only professional photographers take raw files as default - more and more cameras support this and it´s kind of getting more common. in fact, I know more people with raw file photos than with other ones. I´d also really like this feature. see you :) Sven, thank you for confirming the need for this feature. It makes me sad when developers have an attitude like "oh, users who need this should not use my application". I really hope you will reopen this bug. *** Bug 266916 has been marked as a duplicate of this bug. *** Please reopen the bug. KDE KIPI plugins contain the libkdcraw library, which already supports extracting the embedded jpeg preview from the RAW image (if the RAW file contains it - the common RAW formats do). See http://api.kde.org/4.x-api/kdegraphics-apidocs/libs/libkdcraw/libkdcraw/html/classKDcrawIface_1_1KDcraw.html#ade5b61f2b3331dddf18857b98d5862d4 Having this knowledge, I suppose it would be very easy to fix this bug for anyone who already knows the sources - and quite easy even for those (C++ aware) hackers who haven't seem them yet. Created attachment 82984 [details]
proposed patch (just basic stuff, further work needed)
Attaching patch against the git head to enable support for Canon CR2, Nikon NEF & NRW, Pentax PEF, Sony ARW and DNG RAW formats in gwenview (more formats can be easily added by whitelisting their MIME type). It loads the embedded preview image using KDcraw so it is fast.
The code is incomplete, but usable.
review started on reviewboard: https://git.reviewboard.kde.org/r/113397/ Git commit 97d250f3d2c40766e154fac15bf25a8ecdbad879 by Aurélien Gâteau. Committed on 19/11/2013 at 09:21. Pushed by gateau into branch 'master'. RAW preview in gwenview It uses KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for the purposes of quick viewing the photos on the camera display) or loads half-scaled preview (otherwise) so it is fast, implementing was quite easy and theoretically it enables gwenview to support everything dcraw supports (I haven't found a raw file that gwenview doesn't show with this patch). The patch does not perform full demosaicing nor any tweaks (set white balance or so) and I don't think it shall - digikam, darktable or rawtherapee are much more suited for developing the 'digital negatives'. The patch enables support for Nikon NEF and NRW formats, Canon's CR2 and CRW, Pentax PEF, Sony ARW, Fuji RAF, Olympus ORF, Minolta MRW, Panasonic RW2, Samsung SRW and Adobe DNG. If you want to try another format, just adding its MIME type to the list in lib/mimetypeutils.cpp shall be enough. The patch is feature-complete (generating proper thumbnails and viewing the raw images incl. EXIF metadata) and well usable. REVIEW: 113397 M +4 -0 CMakeLists.txt M +1 -0 lib/CMakeLists.txt M +66 -23 lib/document/loadingdocumentimpl.cpp M +2 -3 lib/gwenviewconfig.kcfg M +14 -0 lib/mimetypeutils.cpp M +60 -13 lib/thumbnailprovider/thumbnailgenerator.cpp http://commits.kde.org/gwenview/97d250f3d2c40766e154fac15bf25a8ecdbad879 Wow, nice :) We didn't even release 4.12, but there are already reasons to desire 4.13 :P Please, update the "Version fixed in". It was set to 4.11.3 which is release the fix could not hit even by chance (the patch was ready some 2 weeks after releasing 4.11.3, necessary KDcraw changes were released in 4.12.0). The fix will go to 4.13.0. It's a good feature that deserves appearing in the changelog ;) Thanks. Unfortunately gwenview 15.08.3 ( KDE Frameworks 5.18.0, Qt 5.5.1, libkdcraw23 ) does not show my RW2 photos. Unfortunatelly, many distributions pushed KF5 version of gwenview before digikam folks ported libkdcraw to KF5 - which happened in the 15.12 release. Thus, they are shipping gwenview with feature regression. Please, file a bug against your distribution. *** Bug 127022 has been marked as a duplicate of this bug. *** |