Bug 158578

Summary: dcc send does not work when encryption key has been set
Product: [Applications] konversation Reporter: Niek Beernink <n.beernink>
Component: generalAssignee: argonel <argonel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.0.1   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Niek Beernink 2008-02-29 15:40:59 UTC 
Version:           1.0.1 (using KDE 3.5.8)
Installed from:    Ubuntu Packages

If you set an encryption key for a person using /setkey and then try to send a file to that person. The DCC transfer does not take place and remains in the "Offering" phase until it times out.

To reproduce:

1. Type /setkey mykey nickname 
2. Send a file to this person. (This can either be done by right-clicking on the person's name in the nicklist, the person's name in the channel window or by right-clicking in the query window of the person you're communicating with.)
> DCC transfer initiates, but remains in the offering phase until it times out.
3. Now type /setkey and repeat step 2. 
> File transfer works correctly.

Might also happen for dcc chat, but I've not tested that.
Comment 1 Eike Hein 2008-02-29 17:40:30 UTC 
*** Bug 158584 has been marked as a duplicate of this bug. ***
Comment 2 argonel 2008-02-29 20:01:36 UTC 
i had rather thought CTCP should be encrypted, otherwise /me would be plaintext. is the recipient also konversation? (does konvi's encryption even play nice with other implementations?)
Comment 3 argonel 2008-05-01 07:10:47 UTC 
SVN commit 802897 by argonel:

Blowfish fixes:
-fix FiSH-style +p prefix (to send cleartext to channel)
-encode cleartext, not ciphertext

BUG:158578
-decrypt CTCPs so they can be parsed correctly later
-encrypt only CTCP ACTION, other CTCPs sent in clear

-decrypt TOPIC and CTCP ACTION correctly, however actions now longer show the (e) indicator
-if the topic is encrypted when the key is set, it will be decrypted
-setkey and delkey commands now work with implicit channel or nickname value
GUI:
-show a lock icon beside the input box when a key is set for a channel (found by terwou :)
FEATURE:
-added a /showkey command which displays the destination key in a popup

Non-blowfish fix:
-topic history dialog now knows the *real* time and date on which the topic was set


 M  +10 -14    blowfish/blowfish.cpp  
 M  +1 -1      blowfish/blowfish.h  
 M  +42 -3     channel.cpp  
 M  +5 -2      channel.h  
 M  +1 -1      commit.h  
 M  +1 -2      inputfilter.cpp  
 M  +2 -1      inputfilter.h  
 M  +40 -24    outputfilter.cpp  
 M  +1 -0      outputfilter.h  
 M  +20 -1     query.cpp  
 M  +5 -1      query.h  
 M  +62 -28    server.cpp  
 M  +1 -1      server.h  
 M  +4 -4      viewcontainer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=802897