Bug 158482

Summary:	New Subfolder Button in filters dialog inactive
Product:	[Unmaintained] kmail	Reporter:	Ben Moore <nebzero>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	jjm, karl.sebastian.liebich
Priority:	NOR
Version:	1.9.7
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ben Moore 2008-02-26 22:57:59 UTC

Version:           1.9.7 (using 3.5.8, Debian Package 4:3.5.8.dfsg.1-7 (lenny/sid))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.18-6-686

When creating a new filter for my inbox, I clicked on the folder icon next to the action desired.  When the "Select Folder" dialog appears, I attempted to create a "New Subfolder" by clicking on the button so labeled.  Nothing happens.

Comment 1 Jonathan Marten 2008-02-27 11:31:52 UTC

Confirmed in KMail 1.9.9 (KDE 3.5.9) and trunk.

The problem is that the "New Subfolder" button is disabled in KMFolderSelDlg::slotUpdateBtnStatus() by:

  enableButton( User1, folder() &&
                ( !folder()->noContent() && !folder()->noChildren() ) );

For the root of the folder tree, folder() is NULL and so the button is disabled.

There isn't a simple fix of just enabling the button and accepting NULL as meaning "root", because the required parent folder is passed down to KMFolderTree::addChildFolder().  There, a folder of NULL means "current selected item", which would create the new folder under the selected folder in the *main folder tree* (not the tree displayed in the dialogue).

May need to add an additional parameter to addChildFolder() to specify "ignore what is selected in the GUI".

Comment 2 Jonathan Marten 2008-02-27 11:32:55 UTC

*** Bug 150717 has been marked as a duplicate of this bug. ***

Comment 3 Jonathan Marten 2008-02-27 11:37:30 UTC


*** This bug has been marked as a duplicate of 128796 ***