Bug 158282

Summary: weird internal api
Product: [Applications] khelpcenter Reporter: Oswald Buddenhagen <ossi>
Component: generalAssignee: Documentation Editorial Team <kde-doc-english>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: All   
Latest Commit: http://commits.kde.org/khelpcenter/9db90299598ce0c4b332c826cddcb1bc0486cc26 Version Fixed In:
Sentry Crash Report:

Description Oswald Buddenhagen 2008-02-23 17:42:24 UTC 
the SearchEngine::search() api should be refactored to be truly asynchronous.
currently, it spins a loop with kapp->processEvents() until the search process 
exists, which can have some "nice" side effects.
Comment 1 Pino Toscano 2016-03-18 07:16:08 UTC 
Git commit 9db90299598ce0c4b332c826cddcb1bc0486cc26 by Pino Toscano.
Committed on 18/03/2016 at 07:02.
Pushed by pino into branch 'master'.

Remove "common search program" internal feature

There is a (undocumented) configuration key that switches the search
for any handler to a preset program. However, there are different issues
with it:
- letting handlers to create their indexes as needed, but then not using
  them, makes no sense -- my blind guess is in that far past some distro
  used this to integrate with their own system, but I cannot find more
  hints about that
- the common program seems to behave like a CGI
- the internal implementation is synchronously in a buggy way (cfr
  bug #158282)
- it has not been tested nor used for a decade

Hence, just drop this implementation.

M  +0    -7    khelpcenter.kcfg
M  +12   -112  searchengine.cpp
M  +0    -10   searchengine.h

http://commits.kde.org/khelpcenter/9db90299598ce0c4b332c826cddcb1bc0486cc26