| Summary: | Terminal panel (konsole part) blocks the umount of removable media | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Richard Donkin <kde> |
| Component: | panels: terminal | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander, andresbajotierra, arjunak234, belitsky.a, bryan.cuneo, contego, cp_caverna, diego.ml, emmanuelpescosta099, frank78ac, hauke, heninj, kaabud-kde, karl, kde, kdebugs, lodp, markg85, martonmiklosqdev, matthias.pospiech, mike.vaughn.83, momesana, moraru69, mstu, nate, peebhat, rtguille, schwarzer, sebastian, vshader |
| Priority: | NOR | ||
| Version: | 16.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/bd47eb2e6d80315115bb3f58987162fcb4911b10 | Version Fixed In: | 17.11.80 |
| Sentry Crash Report: | |||
|
Description
Richard Donkin
2008-02-23 11:57:04 UTC
I can confirm that this behaviour is annoying. A newbie would be likely to be totally unaware of what was blocking the unmounting. He would end up yanking the media out without unmounting. A workaround such as that described above ought to be implemented. Unfortunately, it is probably something to be done at the distro level, rather than the KDE level. *** Bug 178380 has been marked as a duplicate of this bug. *** this bug is still present in trunk :( *** Bug 162937 has been marked as a duplicate of this bug. *** *** Bug 191262 has been marked as a duplicate of this bug. *** *** Bug 200806 has been marked as a duplicate of this bug. *** *** Bug 208974 has been marked as a duplicate of this bug. *** *** Bug 188159 has been marked as a duplicate of this bug. *** *** Bug 230404 has been marked as a duplicate of this bug. *** *** Bug 241512 has been marked as a duplicate of this bug. *** *** Bug 172355 has been marked as a duplicate of this bug. *** Is this still an issue with the latest stable version and/or the trunk? (trunk "might" differ since it's not using "udisks"). It is an issue as of Dolphin 1.4 and KDE 4.4.4 in Opensuse 11.3.Once you open a terminal in Dolphin at the mounted device and then close it, you cannot just release it or umount it,(safe remove) it. Just chiming in to say that this highly annoying (and probably very perplexing to new *nix users) bug is still around in KDE SC 4.6.3. I already wrote this up before finding this post; not sure if it's been explained in exactly this way already so I'll just leave this here: If a user closes Dolphin's built-in terminal while currently under an external device's directory tree, the terminal is still open in that directory, regardless of where the user navigates to within Dolphin. This triggers a not-so-obviously-solved error message when trying to unmount the device: "Could not unmount the following device: <device name> One or more files on this device are open within an application." This problem persists until the user re-opens Dolphin's built-in terminal while outside of the device's directory tree. Git commit 8d789f2626243ddc6c763c84e582e8e20afe7689 by Sebastian Dörner. Committed on 25/05/2011 at 23:14. Pushed by doerner into branch 'master'. Don't let hidden terminals prevent unmounting Previous state: When the terminal is hidden, the cwd is not updated anymore. If it was on a removable device when hiding, the hidden terminal might prevent unmounting this device. This patch fixes that bug by changing the cwd to "/" when hiding the panel. REVIEW: 101387 BUG: 158264 FIXED-IN: 4.7.0 M +2 -0 dolphin/src/dolphinmainwindow.cpp M +8 -0 dolphin/src/panels/terminal/terminalpanel.cpp M +1 -0 dolphin/src/panels/terminal/terminalpanel.h http://commits.kde.org/kde-baseapps/8d789f2626243ddc6c763c84e582e8e20afe7689 (In reply to comment #15) This bug is not fixed! Only the special case of comment #14 is fixed. The following more common case is not fixed: When the user is viewing the flash disk, he may then choose to unmount it. Right-clicking the icon in the left panel and selecting 'safely remove' will give an error if he has the terminal panel open. This is not good behaviour, because actually the user is finished with the flash disk and doesn't want to look at it any more. Dolphin should act according to the user's instruction and unmount the flash disk, excercising control of its open terminal panel if necessary. As I said in the initial post, Dolphin should "cd" up to the directory immediately above the flash disk's mount directory (or "/" if you like), and then attempt to unmount the disk. (In reply to comment #16) > As I said in the initial post, Dolphin should "cd" up to the directory > immediately above the flash disk's mount directory (or "/" if you like), and > then attempt to unmount the disk. What about cd-ing with no argument, that will cd to the home directory of the current terminal user? Or what about exit-ing before umount-ing / eject-ing? (In reply to comment #17) > What about cd-ing with no argument, that will cd to the home directory of the > current terminal user? This sounds reasonable. > Or what about exit-ing before umount-ing / eject-ing? This is not correct behaviour, because the user may still want the terminal panel to stay open and follow him around as he navigates further. Also, it must be remembered that the terminal may have spawned another process (such as "less"). So a "cd" command cannot be issued without first determining whether the terminal is idle. Fair enough. The remaining part of the bug depends on KFilePlacesView signalling that a device is to be unmounted. However, I don't know enough about Solid, maybe KFilePlacesView doesn't have access to this information either. *** Bug 277863 has been marked as a duplicate of this bug. *** Confirming the bug in Dolphin 2.0 on KDE 4.8.0 Resetting assignee to default as per bug #305719 [Part of the Dolphin Bug Weeks 2012] I can confirm this with Dolphin 2.1/KDE SC 4.9.2. Still here in Dophin 2.2/KDE 4.10.5. (Kubuntu 13.04) @sparhawk Thanks for your feedback! :) *** Bug 328448 has been marked as a duplicate of this bug. *** Patch to fix this: https://git.reviewboard.kde.org/r/121613/ *** Bug 348201 has been marked as a duplicate of this bug. *** Looks like this is fixed in Plasma 5.3. This problem still exists in Dolphin 16.08.2 / KDE 5.27.0 Yep, still in Dolphin 16.12.3. Proposed patch based on Arjun AK's work submitted to the Phabricator: https://phabricator.kde.org/D7847 Git commit bd47eb2e6d80315115bb3f58987162fcb4911b10 by Elvis Angelaccio, on behalf of Miklos Marton.
Committed on 12/10/2017 at 21:21.
Pushed by elvisangelaccio into branch 'master'.
Don't block unmounting when terminal panel's cwd is the mountpoint
When unmounting a removable media Dolphin checks if there are
some files open on the device before performing the unmount.
If the terminal window in dolphin is open and the to be unmounted path is open,
the unmount process will be blocked.
This patch sets the terminal window current path to the home directory upon unmount request
if the terminal directory is set to the mount path.
The unmount request could came from two sources:
The user could hit right click on the media in the dolphin's places panel and hit unmount.
The user could request an unmount from the indicator applet
This patch was originally written by Arjun AK for the kdelibs4 version
of Dolphin: https://git.reviewboard.kde.org/r/121613/
FIXED-IN: 17.11.80
Differential Revision: https://phabricator.kde.org/D7847
M +49 -19 src/dolphinmainwindow.cpp
M +23 -0 src/dolphinmainwindow.h
M +7 -0 src/panels/places/placesitem.cpp
M +2 -0 src/panels/places/placesitem.h
M +34 -10 src/panels/places/placesitemmodel.cpp
M +8 -2 src/panels/places/placesitemmodel.h
M +12 -0 src/panels/places/placesitemsignalhandler.cpp
M +5 -0 src/panels/places/placesitemsignalhandler.h
M +10 -1 src/panels/places/placespanel.cpp
M +3 -0 src/panels/places/placespanel.h
M +16 -2 src/panels/terminal/terminalpanel.cpp
M +13 -1 src/panels/terminal/terminalpanel.h
https://commits.kde.org/dolphin/bd47eb2e6d80315115bb3f58987162fcb4911b10
|