Bug 157987

The PNG is not compressed (is compressed but in a lossless way as wikipedia says http://en.wikipedia.org/wiki/Portable_Network_Graphics ), than I don't see the problem.

The problem is that, e.g. the original JPG weighs 80KB (800x800) and the resulting PNG weighs 1MB.

That's not smart to convert from the *lossy* formart to *lossless*.

It's like getting covers @128Kbit mp3 and saving them as FLAC files.

yes, you are right, but the thing is that if we have to manage a lot of different types of images we have to change a lot of code. Plus png is the only complete free type for a bitmap image.

I've always thought that showing an image using means of Qt library is as easy as using few library calls. So, I don't see that there has to be any kind of complicated management.

Of course, PNG is open but since Qt natively supports GIF and JPEG and Qt is covered by GPL I see no reason not to use these two image formats in Juk. If we followed you logic, then every other application in KDE should have stopped supporting GIFs and JPEGs - which not an issue.

I suppose Scott Wheeler should voice here.

I'd tend to agree that the conversion isn't necessary, that said (a) Michael Pyne wrote this code, not me, so usually this would be more up to him and (b) I'm not really maintaining JuK in KDE 4.  (I originally didn't want it shipped because of that, but some of the KDE folks felt it was important to have some media player there for KDE 4.)

So, someone, please, reassign this bug to Michael Pyne. If he decides it's not worth it then I suppose it's safe to close it as WONT_FIX.

I'll go ahead and have downloaded covers saved unconverted.  The smaller thumbnail sizes will still need to be PNG however.

SVN commit 806109 by mpyne:

Fix bug 157987 (JuK unnecessarily converts all cover art to PNG) in trunk.  Now when JuK downloads cover
art it will simply copy it in place instead of converting it to PNG en route.

CCBUG:157987


 M  +41 -13    covermanager.cpp  
 M  +3 -1      covermanager.h  
 M  +7 -12     playlist.cpp  
 M  +10 -10    webimagefetcher.cpp  
 M  +2 -1      webimagefetcher.h  
 M  +1 -13     webimagefetcherdialog.cpp  
 M  +1 -1      webimagefetcherdialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=806109

SVN commit 806110 by mpyne:

Fix bug 157987 (JuK unnecessarily converts cover art to PNG) in the 4.0 branch.

BUG:157987


 M  +41 -13    covermanager.cpp  
 M  +3 -1      covermanager.h  
 M  +7 -12     playlist.cpp  
 M  +10 -10    webimagefetcher.cpp  
 M  +2 -1      webimagefetcher.h  
 M  +1 -13     webimagefetcherdialog.cpp  
 M  +1 -1      webimagefetcherdialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=806110