Bug 157467

Summary: [PATCH] Use Save/Discard instead of Yes/No on exit dialog
Product: [Applications] kwordquiz Reporter: David Benjamin <davidben>
Component: generalAssignee: Peter Hedlund <peter>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Use KStandardGuiItem::save(), etc.

Description David Benjamin 2008-02-09 01:02:38 UTC 
Version:           0.8.9 (using KDE 4.0.0)
Installed from:    Compiled From Sources
OS:                Linux

(This behavior is actually consistent with other KDE apps this time. ;-) See KWrite.)

When exiting KWordQuiz on a modified document, a dialog appears. The buttons say "Yes/No". They should be labeled with verbs.

References:
KWrite
KOffice
http://wiki.openusability.org/guidelines/index.php/Guidelines:Buttons
Comment 1 David Benjamin 2008-02-09 01:05:11 UTC 
Created attachment 23484 [details]
Use KStandardGuiItem::save(), etc.

I wasn't sure whether to use discard() or dontSave(). Other KDE apps seem to
use discard(), so I guess that's the KDE convention... which makes me wonder
what the point of dontSave() is.

(The patch also includes a little change to avoid the

QLayout: Attempting to add QLayout "" to KWordQuizApp "MainWindow#1", which
already has a layout

warning that occurs at startup. I thought it wasn't worth it to open two bugs
for a one-liner each.)
Comment 2 Peter Hedlund 2008-02-10 03:57:33 UTC 
SVN commit 773063 by hedlund:

Use Save/Discard instead of Yes/No on exit. Patch by David Benjamin.

BUG:157467

 M  +2 -2      kwordquiz.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=773063