| Summary: | Bookmarks and reviews are not saved immediately and can be lost after a crash | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Vladimir Kuznetsov <ks.vladimir> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | egxoun8uya67izy, finex |
| Priority: | NOR | ||
| Version: | 0.6 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Vladimir Kuznetsov
2008-02-06 07:27:31 UTC
> Currently okular saves bookmarks and reviews only when closing a document.
Not entirely true, annotations are saves each 5 minutes.
I could have bookmarks saved at the same time, but it would be so important save after ANY change?
Actually, I've observed the bug with bookmarks after actual power failure and only then I've tested it manually with annotations. I think that saving bookmarks and annotations every 5 minutes should be fine enough. Another possibility is to save them when they lose the focus, or when the user scrolls to another page. Saving on focus loss (in addition to 5 minutes) is a good idea. KNotes does this. Changed severity to "crash". I hope to have selected only the right bugs (>100) :-) Hi, this is indeed a problem, loosing your recent bookmarks. However the problem here is much worse. In case of a crash Okular will not only loose bookmarks set in the last run but *ALL* bookmarks for the file that was open. I am using Okular 0.8.3 on KDE 4.2.2/3 on Arch GNU/Linux and I saw this happen numerous times. P.S to make it worse, Okular is the main reason for crashes and freezes on my machine due to Intel drivers being broken for months now, and scrolling in Okular drags X and then my system to hell. P.P.S I keep my books on remote storage and only symlink the one I'm reading to my home. When I remove the symlink bookmarks, and everything else, for the file are lost. I don't want to open a bug report for this - as you will say it's not a bug. But was changing this behaviour ever considered? SVN commit 1066286 by pino: Change the saving strategy for bookmarks: instead of saving them manually or at closing, save them after each action. This should avoid any bookmark loss due to premature crash or similar abnormal closing. BUG: 157246 BUG: 213206 Also, the above change triggers the D-Bus synchronisation of the internal bookmark manager of the various Okular instances; react to those changes properly by updating the own info (because of the changes in the bookmark manager of another instance). BUG: 216239 On the technical note, keep the cache of known file just with the bookmark address instead of the group itself (which gets changed behind our back). M +98 -25 bookmarkmanager.cpp M +2 -0 bookmarkmanager.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1066286 |