| Summary: | shift + tab gives focus to tab bar | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Alex Merry <alex.merry> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andreas.sahlbach, charlyghislain, inform, rgo, roland.leissa |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Alex Merry
2008-01-31 17:37:54 UTC
The tab bar gains focus in this case. Pressing the arrow keys changes tabs (but only once, since it gives the focus to the terminal). Confirmed on trunk. Is this the desired result? It seems strange that shift+tab only lasts for 1 tab change. I don't see why Konsole needs another shortcut to change tabs. I think this is something from Qt but I haven't looked into it closely. Same problem here. I find this bug very annoying as I use shift + tab quite often in Vim's command line. Me too. A fix would be much appreciated. The shortcut can be changed from Shortcuts Settings but this has no effect Bug present in konsole 2.2, KDE 4.2.60 (KDE 4.3 >= 20090116) Another vim user that need a fix. Thanks! Bug present in konsole 2.3, KDE 4.3.1 (KDE 4.3.1 >= 20091012) Any news? Sure. Bug is annoying as hell but is ignored close to 2 years now. (In reply to comment #10) > Sure. Bug is annoying as hell but is ignored close to 2 years now. so I sent this comment.I like konsole but I have to use Terminal(xfce) for this bug :-/ ouchh two years without konsole and I'm waiting for it :-) If anyone can try this patch, it appears to work in my quick testing.
Index: ViewContainer.cpp
===================================================================
--- ViewContainer.cpp (revision 1034362)
+++ ViewContainer.cpp (working copy)
@@ -429,6 +429,7 @@
_tabBar = new ViewContainerTabBar(_containerWidget,this);
_tabBar->setDrawBase(true);
_tabBar->setDocumentMode(true);
+ _tabBar->setFocusPolicy(Qt::ClickFocus);
_newTabButton = new QToolButton(_containerWidget);
_newTabButton->setIcon(KIcon("tab-new"));
This patch appears to work fine. I'll commit it before the next release. One thing I noticed if you split the view, 'shift+tab' will change the split-views. (In reply to comment #13) > This patch appears to work fine. I'll commit it before the next release. > > One thing I noticed if you split the view, 'shift+tab' will change the > split-views. Perhaps I can try the patch in a un-official package of kde-base. I'll tell you. (In reply to comment #13) > This patch appears to work fine. I'll commit it before the next release. > > One thing I noticed if you split the view, 'shift+tab' will change the > split-views. Sorry, I couldn't try it yet. I'm eager to return to konsole :) Thanks for the patch SVN commit 1037396 by hindenburg: Fix issue where Shift+Tab would focus tab bar. BUG: 157039 M +1 -0 ViewContainer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1037396 SVN commit 1037397 by hindenburg: Fix issue where Shift+Tab would focus tab bar. CCBUG: 157039 M +1 -0 ViewContainer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1037397 SVN commit 1059061 by hindenburg: Correct terminal focus issues when clicking on tabbar. BUG: 215382 CCBUG: 157039 M +1 -1 ViewContainer.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1059061 For reference, if you the new and close tab buttons enabled, using SHIFT+Tab will still traverse the 3 widgets (new, close, terminal). |