Bug 156890

Summary:	[PATCH] KUrlNavigator should emit a signal when its editable state changes
Product:	[Unmaintained] kfile	Reporter:	David Benjamin <davidben>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	adds signal

Description David Benjamin 2008-01-29 02:42:14 UTC

Version:            (using KDE 4.0.0)
Installed from:    Compiled From Sources
OS:                Linux

KUrlNavigator should emit a signal when it's editable state changes, otherwise applications have no notification when the user clicks the button to change the state.

This is needed for a TODO in dolphinmainwindow.cpp; the "Show Full Location" action isn't synchronized with the KUrlNavigator.

Comment 1 David Benjamin 2008-01-29 02:44:13 UTC

Created attachment 23342 [details]
adds signal

Patch to add the missing signal... hopefully I didn't do anything horribly
stupid with naming it. :-/

(And I'm not sure what the policy on API changes is... this doesn't break ABI
though. :-D It still properly links to Ubuntu's Dolphin binary.)

Comment 2 Peter Penz 2008-02-07 08:24:35 UTC

SVN commit 771916 by ppenz:

Emit a signal if the editable state of the URL navigator has been changed (thanks to David Benjamin for the patch).

BUG: 156890

 M  +1 -0      kurlnavigator.cpp  
 M  +6 -0      kurlnavigator.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=771916