| Summary: | changing of iconsize doesn't affect on dekstop | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Rastislav Krupanský <rastislav.krupansky> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | snapshot | ||
|
Description
Rastislav Krupanský
2008-01-24 10:48:32 UTC
Created attachment 23232 [details]
snapshot
as you can see on snapshot, some icons have correct size (16), but some are
still huge.
There is no kdesktop and kicker in KDE 4, but plasma. Sorry, i didn´t know it. :-) yes, the way we are handling icons it only applies to new icons created. i'm debating whether we even need to keep this sizing feature in the main control panel given where we're headed with desktop icons in general though. Setting the icon size for icons on the desktop works partly. You have to restart plasma to apply the changes (killall plasma; plasma)
So this bug should be fixed, the size setting should be applied as soon as you hit the Apply button in "system settings -> appearance -> icons -> advanced -> Desktop/File Manager".
After some testing and playing, I found out, that the situation is currently the following:
1. The size you setup in the system settings is the 'minimum size' a desktop icon can have. If you set this size to 128 and restart plasma, then even by using the resize handle, you can't scale them smaller than 128.
2. There are differences between logging-out / logging-in or just restarting plasma via 'killall plasma; plasma'. There seems to be a saved value like 'system settings icon size at the time of the last logout'.
To explain my different observations I will use the following variables:
LSSIS = Latest System Settings Icon Size, the size that was set in system settings, the last time you hit the 'Apply' button
LLIS = Latest Logout Icon Size, the value of LSSIS during the last time you logged out
CDIS = Current Desktop Icon Size, the actual size a desktop icon currently has
The following two scenarios include the user actions 'Change desktop icon size via system settings' and 'restart plasma via killall plasma; plasma'.
My observation results:
IF (CDIS < LSSIS) THEN after plasma restart desktop icons are scaled to the value of LSSIS
IF ((CDIS > LSSIS) && (LSSIS < LLIS)) THEN after plasma restart desktop icons are only scaled to the value of LLIS instead of LSSIS, but it's possible to scale the icons manually down to LSSIS via the resize handle.
the icon size configured here is only used for a sane default as minimum size when the icons are created, now i think changing all the sizes of all the icons in the desktop would be bad, because the point of plasma is that everything should be scalable as your wish, it could be provided a facility that sets the minimum icon size accordingly when the size changes but even that is highly debatable. i was thinking about only using the size of that setting when the icon is created and use a fixed and way lower minimum size. this approach would be easier to implement and give the user way more freedom. i think i'll come up with a patch in a moment If the default size of icons change then we'll need to consider the the default spacing. I think it would be a good idea to scale the spacing based on the ratio between spacing and icon size now. Maybe a map should be created which matches icon spacing to default icon size. bleurk, now i rememmber why i had done this way, it seems it's more tricky than it seems to have all the icons with same initial size, damn text :) i will do some other experiments, but atm changing anything it only does make it to stink more... Folderview is a much better system and has fixed this bug :) |