Bug 156350

Summary:	fix for "automagic" dependency for assuan if it is really optional
Product:	[Applications] kleopatra	Reporter:	David <StormByte>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	CLOSED FIXED
Severity:	normal	CC:	osterfeld
Priority:	NOR
Version First Reported In:	outdated (old bug dump)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	FindAssuan.cmake.patch

Description David 2008-01-21 23:25:37 UTC

Version:           SVN (using Devel)
Installed from:    Compiled sources
OS:                Linux

I've made a patch for cmake/modules/FindAssuan.cmake in order to only look and activate assuan if WITH_Assuan is true (as the rest of optional dependencies) and thus, not install assuan compatibility if not desired and libassuan is installed.

I attach the patch.

Comment 1 David 2008-01-21 23:26:08 UTC

Created attachment 23185 [details]
FindAssuan.cmake.patch

Comment 2 David 2008-01-22 06:14:43 UTC

I tested that patch and works, avoids detection of assuan if no WITH_Assuan is passed to cmake (assuan maybe installed in this case, but won't be used), and compiles with assuan if WITH_Assuan is set.

Comment 3 Allen Winter 2008-01-23 17:51:29 UTC

David,

Instead of your patch, can you try changing the line
find_package(Assuan)
to
macro_optional_find_package(Assuan)

let us know if that does what you want.
this change automatically supports the WITH_Assuan option.

Comment 4 Frank Osterfeld 2008-02-12 09:26:23 UTC

SVN commit 773956 by osterfeld:

make kleopatra compile without assuan
Use macro_optional_find_package, so Assuan support can be switched off using 
-DWITH_Assuan=no (as suggested by Allen)
I suggest to always have no-assuan build dir around to ensure kleopatra builds without assuan, too
BUG:156350
CCMAIL:marc@kdab.net

 M  +18 -12    CMakeLists.txt  
 M  +1 -1      ConfigureChecks.cmake  


WebSVN link: http://websvn.kde.org/?view=rev&revision=773956