Bug 155799

Summary: Favicon draws over focus glow in Oxygen theme
Product: [Plasma] Oxygen Reporter: David Benjamin <davidben>
Component: styleAssignee: Camilla Boemann <cbo>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 4.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Picture of the problem

Description David Benjamin 2008-01-15 04:04:24 UTC 
Version:            (using KDE KDE 4.0.0)
Installed from:    Ubuntu Packages
OS:                Linux

(I know this is super minor, but meh... a bit of polish couldn't hurt.)

Using the Oxygen theme, the favicon in the location bar draws over Oxygen's focus glow by a few pixels.

Steps to Reproduce:
1. Open Konqueror to anything
2. Click the address bar to focus it

The pixels just above and belove the favicon appear white instead of the blue (or whatever) focus glow.
Comment 1 David Benjamin 2008-01-15 04:07:39 UTC 
Created attachment 23044 [details]
Picture of the problem

I know, it's only 40 pixels. :-)
The effect is more noticeable when the focus glow has a strong contrast, like
black, as displayed.
Comment 2 Camilla Boemann 2008-01-24 03:02:31 UTC 
I think it will be hard to do anything about, but I do accept it as something that shouldn't be there in an ideal world.
Comment 3 David Benjamin 2008-01-25 00:11:00 UTC 
Hrm.

Out of curiosity, why? Is it hard to overlay transparent images within such a widget in Qt? It seems that the current setup could also cause issues should a future theme put a gradient in the LineEdit widget.

I tried to poke around the code to figure out what was going on, but my unfamiliarity with Qt, the code, etc. got in the way. (Plus the websvn interface is evil and confusing and hard to use. :-D)
Comment 4 Camilla Boemann 2008-01-25 07:09:13 UTC 
Uhm no it's because the icon is not transparent

Basically the widget paints it's back ground and then qt paints the icon and text on top

and konqueror tries to make the widget smaller by using a smaller font, leaving the icon relative bigger.

the icon then erases some of the widget
Comment 5 Camilla Boemann 2008-08-14 20:05:22 UTC 
SVN commit 847088 by boemann:

Fiddle with margins to save some pixels in lineedits,comboboxes,pushbuttons,and 
spinboxes
Fix favicons spoiling the glow in linedits.
BUG:168986
BUG:155799


 M  +48 -11    oxygen.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=847088