| Summary: | light-table useability, possible improvements | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Arnd Baecker <arnd.baecker> |
| Component: | LightTable-Workflow | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 0.9.3 | ||
| Target Milestone: | --- | ||
| Platform: | Debian stable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.9.4 | |
| Sentry Crash Report: | |||
| Attachments: |
address 1.) , 2.)
address 1.) , 2.), updated patch |
||
> > 3.) Using (e.g) SHIFT-Click to 100% zoom to a specific point would be > useful. Loupe could be really useful for such things. > Suggestion: use z (or Z) (as eg. in gqview) as single letter toggle > for 100% zoom/fit to window. And: > Suggestion: allow for 0, 1, ... 5 to have the same > functionality as CTRL-0, ..., CTRL-5. Maybe there should be profile of one letter shortcuts for most common actions in whole digiKam and ShowFoto? Loupe: well, code-wise this would be quite a substantial addition, here I would prefer just a simple solution. Essentially: If I get the ok for 1.) - 5.) in the suggested (or some better way), I would implement them (should be pretty easy). However 6.) and 7.) are more most likely more complicated ... Note to the original poster: 7 wishes in one bug is a lot...
Let's tackle some of them:
2). Invalid.
Using "Settings"/"Configure Shortcuts" one can define
"z" as alternative short-cut in addition to CTRL-SHIFT-0.
Note that for consistency this should be done
both for the short-cuts in digikam and the image editor.
Only valid point: make CTRL-SHIFT-0 behave as a toggle.
4.) Invalid.
Created attachment 24455 [details]
address 1.) , 2.)
This patch solves:
- CTRL+ALT+0 should behave as a toggle between
fit-to-window and 100% zoom
(also for the light-table but
not yet for the image-editor)
- CTRL+ALT+0 should be centered
- moving the zoom slider, the view should stay centered
around the current point
Next steps (after testing and applying this patch...):
A) same for the image editor
B) SHIFT+Click: 3.)
C) 5.)
Arnd, I waiting Mik tests before to review code. Gilles Sorry, cannot compile: imagepannelwidget.cpp: In member function 'void Digikam::ImagePannelWidget::slotZoomSliderChanged(int)': imagepannelwidget.cpp:368: error: 'class Digikam::ImageRegionWidget' has no member named 'setZoomFactorSnapped' make[3]: *** [imagepannelwidget.lo] Error 1 make[3]: Leaving directory `/home/mikolaj/kde/head/extragear/graphics/digikam/libs/widgets/imageplugins' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/mikolaj/kde/head/extragear/graphics/digikam/libs/widgets' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/mikolaj/kde/head/extragear/graphics/digikam/libs' make: *** [all-recursive] Error 1 Will try tomorrow with fresh checkout. Hi Mikolaj, setZoomFactorSnapped comes from the other patch (http://bugs.kde.org/show_bug.cgi?id=157314). Make sure that you start from a clean svn (i.e. `svn diff` should show nothing). Here the compile of the above patch work with current svn. Best, Arnd Thanks, works as advertised. Arnd, i cannot apply your patch against svn. There are few reject here... Can you update it ? Gilles Created attachment 24580 [details]
address 1.) , 2.), updated patch
Arnd, Patch check. work fine for me. Gilles SVN commit 808386 by cgilles: digiKam from KDE3 branch : patch from Arnd to fix points 1/ and 2/ from B.K.O #155046 CCBUGS: 155046 M +5 -0 digikam/albumwidgetstack.cpp M +1 -0 digikam/albumwidgetstack.h M +2 -2 digikam/digikamview.cpp M +29 -1 libs/widgets/common/previewwidget.cpp M +4 -1 libs/widgets/common/previewwidget.h M +5 -0 utilities/imageeditor/canvas/canvas.cpp M +1 -0 utilities/imageeditor/canvas/canvas.h M +9 -1 utilities/imageeditor/editor/editorwindow.cpp M +16 -0 utilities/lighttable/lighttableview.cpp M +2 -1 utilities/lighttable/lighttableview.h M +1 -2 utilities/lighttable/lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=808386 SVN commit 808403 by cgilles: digiKam from trunk : backport commit #808386 from KDE3 branch CCBUGS: 155046 M +5 -0 digikam/albumwidgetstack.cpp M +1 -0 digikam/albumwidgetstack.h M +1 -1 digikam/digikamview.cpp M +28 -0 libs/widgets/common/previewwidget.cpp M +2 -0 libs/widgets/common/previewwidget.h M +10 -0 project/project.kdevelop M +5 -0 utilities/imageeditor/canvas/canvas.cpp M +9 -8 utilities/imageeditor/canvas/canvas.h M +9 -1 utilities/imageeditor/editor/editorwindow.cpp M +17 -0 utilities/lighttable/lighttableview.cpp M +1 -0 utilities/lighttable/lighttableview.h M +7 -9 utilities/lighttable/lighttablewindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=808403 What about this one? 1-5) have been fixed (shortcuts can always be changed by the user) 6) is not reproducable here, it is always fast 7) is a normal behavior when using D&D (or not?) I have tested this with 0.10... I just assume that 0.9.5 behaves the same. So I would suggest to close this one. Andi I'm agree. Gilles |
Version: 0.9.3 (using KDE KDE 3.5.5) Installed from: Debian stable Packages While going through a couple of thousands images using the light-table, I collected a couple of issues which could be improved: 1.) When activating the 100% view via CTRL-SHIFT-0 it should always be centered (both horizontally and vertically, the vertical centering does not seem to work) 2.) To activate the 100% zoom, the keyboard short-cut CTRL-SHIFT-0 requires two hands (at least the way I type ;-). I.e. one has to leave the mouse. To get out of the 100% CTRL-ALT-E (fit-window) is used, which is also not easy to type. Suggestion: use z (or Z) (as eg. in gqview) as single letter toggle for 100% zoom/fit to window. 3.) Using (e.g) SHIFT-Click to 100% zoom to a specific point would be useful. 4.) Setting the rating via CTRL-0 ... CTRL-5 is very stressing for the left hand (just try it with 500+ images). Suggestion: allow for 0, 1, ... 5 to have the same functionality as CTRL-0, ..., CTRL-5. 5.) The image, for which the zoom/pan/etc is done should be activated/marked as the current one. By this it is ensured, that a rating is associated to the image one is currently considering. 6.) Somehow the light-table does not feel too responsive on changes of the rating: i.e., it takes a while, until a changed rating is displayed. 7.) Sometimes (when using drag&drop) an image in the panel is updated, even though it is currently displayed (i.e., this takes a short time).