| Summary: | plasmoid icon resize weirdness | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Shieldfire <shieldfire> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Shieldfire
2008-01-03 10:09:28 UTC
SVN commit 756574 by mart: make icons at most 256 pixels BUG: 155010 M +1 -0 icon.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=756574 Why isn't this good? Why should there be an arbitrary limit on how big an icon should be? maybe set it even bigger than 256, but at the moment the main reason i think that scaling it beyond a certain size takes an insane amount of cpu and nearly freezes plasma, at least on a not so powerful cpu Painting at the new size (and thus the large cpu usage) only happens after the user releases the mouse button though, no? Resizing it smaller again shouldn't be difficult. Another way to get around the CPU usage would be to ensure that the graphical icon doesn't go beyond a certain size (which would make sense especially for raster graphics) but allow the applet to be resized so that the user can make more text visible. The minimum screen size is 800x600 and according to wikipedia the current largest DVI resolution is 3840x2400. 256 pixels is therefore somewhere between 7% and 32% of the screen width. Choosing any other value will still have a huge variance what the visible maximum turns out to be... I won't push this, but setting a maximum size for no good reason doesn't really seem right. And if there is a good reason, it's likely general to all applets and should probably dealt with in plasma. yes, this commit as well as this bug report are completely bogus. this really is a matter of "well, if you don't want an icon that big, don't make them that big!" limiting others in this way is not Plasma(tm). SVN commit 756606 by aseigo: arbitrary upper limits are probably not a good idea; just don't make them so big if you won't want them that big. as for cpu usage, even HUUUGE icons on my 1.8Ghz machine don't even make plasma cough. i'm sure with complex enough svg icons and a slow enough processor it would have a rendering impact but, again, just don't make them so frigging huge then. CCBUG:155010 M +0 -1 icon.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=756606 ok, nevermind :) |