| Summary: | BiDi issue in KDE window titles - multiple windows having title foo, foo <n> | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | lɛʁi לערי ריינהארט <gangleri> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | elcuco |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
screen dump · « KDE 3.5.5 » · BiDi issue in Konqueror window titles · 01.jpg
screen dump · « KDE 3.5.5 » · BiDi issue in FireFox window titles · 01.jpg The screen after the fix |
||
|
Description
lɛʁi לערי ריינהארט
2007-12-30 06:45:05 UTC
Created attachment 22770 [details]
screen dump · « KDE 3.5.5 » · BiDi issue in Konqueror window titles · 01.jpg
either the « < » character or the « > » character are shown at the wrong
place
Created attachment 22771 [details] screen dump · « KDE 3.5.5 » · BiDi issue in FireFox window titles · 01.jpg either the « < » character or the « > » character are shown at the wrong place Please see also https://bugzilla.mozilla.org/show_bug.cgi?id=406891 Bug Bugzilla@Mozilla 406891 – BiDi problem in « Mozilla Firefox <n> » suffix of the window titles Diego Iastrubni can you please « CONFIRM » this bug / report ? Thanks in advance Reinhardt lɛʁi לערי ריינהארט I am not sure the problem is in kwin... I mean, it's the application's fault it send "broken" text to be displayed. IMHO the problem are the applications. Who handles the situation in which 2 windows have the same title? is that kwin adding "(%n)"? sorry for the long delay ;-) The numbering of windows with same titlebar text is done by KWin, specifically in Client::setCaption() in kdebase/workspace/kwin/client.cpp . If the code is not right for bidi, I have no idea how it should be fixed. oh... in that case, the fix is quite simple: if string is RTL, to the end of the string add "&LRM;". It should not be that hard to hack something, and it will have no effect on LTR titles. Whats the policy for commiting this into trunk right now? "commit and wait for someone to shout" or something more educated like personal emails/mailing lists? Please simply commit the fix if you have it. This is my proposed patch: simply add LRM to the end of each line. In RTL it will fix the issue, and in LTR it will do nothing. Created attachment 26838 [details]
The screen after the fix
Stupid bugzilla... well, this was closed in r 846529 : http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/client.cpp?r1=845772&r2=846529 |