Bug 154832

Summary:	Blurry Icons in Panel Taskbar
Product:	[Unmaintained] plasma4	Reporter:	Craig Duquette <cduquette>
Component:	panel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Craig Duquette 2007-12-29 21:48:23 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

If you hover over the tooltip and compare that icon to the panel's icon you'll see it's blurrier than the tooltip. This is because the panel is being displayed at 47px instead of 48px.

Proposed fix:
If one removes the -1 from line 90 of
workspace/plasma/containments/panel/panel.cpp
(height += topHeight - 1;) you get nice sharp icons. The only problem
is the panel is drawn 1 pixel up.

This can be resolved by changing the +1 to +2 in
kdebase/workspace/plasma/plasma/panelview.cpp
(geom.moveTopLeft(QPoint(screenGeom.left(), screenGeom.bottom() -
size.height() + 1));)

The panel appears to render correctly now with these changes, but I'm
not sure if they're proper changes. Does anyone see anything wrong
with committing a fix like this? We'll also need to update the code
for when the panel is on top or the sides.

Comment 1 Jason Stubbs 2007-12-30 08:33:02 UTC

SVN commit 754550 by jstubbs:

Initialize the graphicsview with default properties regardless of which
constructor is called. This is important to the panel because QGraphicsView
has an off-by-one bug when using the default AlignCenter alignment and an
odd height.

CCBUG: 154832


 M  +15 -10    view.cpp  
 M  +2 -0      view.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=754550

Comment 2 Jason Stubbs 2007-12-30 08:34:31 UTC

SVN commit 754552 by jstubbs:

Fix the width and height calculations of the panel to get the correct geometry

BUG: 154832


 M  +6 -6      panel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=754552