Summary: | analog clock: no context menu | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Maciej Pilichowski <bluedzins> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Maciej Pilichowski
2007-12-23 20:35:06 UTC
SVN commit 752290 by jstubbs: Derive from Applet rather than Containment so that all the Applet goodies such as context menus are available BUG: 154552 M +1 -1 clock.cpp M +2 -2 clock.h WebSVN link: http://websvn.kde.org/?view=rev&revision=752290 this patch is incorrect. deriving from containment should not interfere with context menus. investigating why this would be the case is really what needs to happen. i'd guess that either there is a missing isContaintment() somewhere or else maybe the qgraphicsitem_cast in Containment::contextMenuEvent isn't working as expected. SVN commit 753472 by jstubbs: Don't try and display the containment context menu when isContainment() is false. Also, call Applet's contextMenuEvent() rather than calling QGraphicsItem's directly. CCBUG: 154552 M +2 -2 containment.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=753472 SVN commit 753474 by jstubbs: Change back to a containment now that the context menu displays correctly CCBUG: 154552 M +1 -1 clock.cpp M +2 -2 clock.h WebSVN link: http://websvn.kde.org/?view=rev&revision=753474 There's a bug in qt4.3 that won't be fixed until qt4.4 that context menu events aren't propogated to parent items. I previously moved the workaround that was in Applet into Widget, but Containment hadn't been updated for it. |