| Summary: | cannot search in account, only in sub-folders | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Thorsten Staerk <dev> |
| Component: | search | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | SVN (3.5 branch) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | return from the search | ||
|
Description
Thorsten Staerk
2007-12-04 20:59:43 UTC
This problem occurs on all imap servers I tested: cyrus and exchange.
If I add
if ( !mFolder->imapPath().contains("tho") ) return;
to SearchJob::searchCompleteFolder(), then it works for me, as all my sub-folders contain "tho". I see, as soon as you create a KIO::SimpleJob with the URL for your ACCOUNT, your imap kioslave blocks. You have to hand over a FOLDER in the URL to KIO::SimpleJob.
SVN commit 745678 by tstaerk: Do not stall if a search contains the "/" folder of an imap account. CCBUGS:153448 CCMAIL:spamgate@staerk.de M +3 -0 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=745678 SVN commit 745806 by tilladam: Merged revisions 745678 via svnmerge from svn+ssh://tilladam@svn.kde.org/home/kde/branches/KDE/3.5/kdepim ........ r745678 | tstaerk | 2007-12-07 01:21:20 +0530 (Fri, 07 Dec 2007) | 4 lines Do not stall if a search contains the "/" folder of an imap account. CCBUGS:153448 CCMAIL:spamgate@staerk.de ........ _M . (directory) WebSVN link: http://websvn.kde.org/?view=rev&revision=745806 SVN commit 745807 by tilladam: Merged revisions 745678 via svnmerge from svn+ssh://tilladam@svn.kde.org/home/kde/branches/KDE/3.5/kdepim ........ r745678 | tstaerk | 2007-12-07 01:21:20 +0530 (Fri, 07 Dec 2007) | 4 lines Do not stall if a search contains the "/" folder of an imap account. CCBUGS:153448 CCMAIL:spamgate@staerk.de ........ M +3 -0 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=745807 I want to stress out that this change allows me to * have a virtual folder "all e-mails" * search within all my company e-mails * as a result of the above, do my work for the first time. Next steps before setting this bug to FIXED: * commit to trunk if needed * see if we can improve the kioslave SVN commit 746103 by tstaerk: Do not stall when searching in the "/ folder" of an imap account. BUGS:153448 M +13 -10 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=746103 Created attachment 22427 [details]
return from the search
Indeed the problem is that assignJobToSlave makes the kioslave stall. The job itself may even start executing, this does not block anything, it just comes back with no answer. I want to commit the last patch, so the search will return. Anyway, I first want to test in an enterprise-environment. A very minor style nitpick: >KIO::Scheduler::assignJobToSlave(mAccount->slave(), job); should be >KIO::Scheduler::assignJobToSlave( mAccount->slave(), job ); This is in more places, please respect the KMail coding style a bit more. Otherwise, thank you very much for working on these issues and especially for also porting them to trunk. I trust that you test those patches well, so always feel free to commit. SVN commit 746616 by tstaerk: kioslave does not block and mail search returns. CCBUGS:153448 M +13 -8 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=746616 *** Bug 122621 has been marked as a duplicate of this bug. *** SVN commit 747792 by tstaerk: kioslave does not block and mail search returns. CCBUGS:153448 M +11 -6 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=747792 SVN commit 748275 by tstaerk: kioslave no longer blocks, search returns BUGS:153448 M +10 -5 searchjob.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=748275 |