Summary: | live filter does not work if no text is displayed under thumbnails | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Rick W. Chen <stuffcorpse> |
Component: | Albums-Filters | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.9.3 | |
Sentry Crash Report: |
Description
Rick W. Chen
2007-11-25 00:00:19 UTC
I just use this bug entry to add two more proposals to this filter: 1. The filter entry survives closing digikam. I think it should be reset when the application is started. Otherwise you will navigate with a filter without noticing it. 2. I propose to put "Search" and the little x-box for delete filter in front of it for convenience Ad #0: I see three options a) disable filter bar if no text is displayed below the images b) always include the filter for filenames c) have a configuration menu to select the fields used for filtering (Code-wise b) would be the simplest) Ad c#1: 1.) Currently all the new filters (tex filter, file type, and rating) survive saving (note that the side-bar tags filter does not, which is inconsistent). Would some clear visual indication, that some type of filtering is active, help? (Maybe it is needed/good anyway?) However, I don't know what a good visual indication would be. 2.) This is also mentioned in http://bugs.kde.org/show_bug.cgi?id=133191#c11 (all important points, which we should not forget, BTW), and in http://bugs.kde.org/show_bug.cgi?id=133191#c15 Mikolaj suggested to use instead of the text "Search" the "kitchen utensil - funnel - used everywhere where KDE filters things. There are already loupes in digiKam interface and another could create confusion." Personally, I like the icon variant a bit more than the "Search" text. This and the deleted filter should be implemented IMO. Once there is consensus about what to do, I can have a look at it. Arnd, Gerhard, About c#1-1: current implementation do not store filter settings between sessions. Only Rating Filter Condition is saved. About c#1-2: This is not the object of this file. Please do not mix. It infernal to manage (:=)) About original post from Rick, I will commit change to enable/disable Text filter and Rating filter accordinly with album icon view settings. Note: 1/ Mime Type fileter still always enable. 2/ About Text filter and filename, i think it's a non sence to make a search on filename string if this one is disable on album icon view settings. Gilles SVN commit 742178 by cgilles: digiKam from KDE3 branch: Rating and Text filters are enabled/disabled accordinly with album icon view settings. BUG: 152843 TODO: KDE4PORT M +18 -10 albumiconviewfilter.cpp M +2 -2 albumiconviewfilter.h M +4 -4 digikamapp.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=742178 |